[HttpKernel] Deprecate AddAnnotatedClassesToCachePass and related code infrastructure
#53801
Conversation
nicolas-grekas
force-pushed
the
hk-deprec-annotated-classes
branch
from
ab04c1a
to
599867d
Compare
| @@ -17,6 +17,8 @@ | |||
| * Allow adding classes to the class cache. | |||
| * | |||
| * @author Fabien Potencier <fabien@symfony.com> | |||
| * | |||
| * @internal since Symfony 7.1, to be deprecated in 8.1; use Symfony\Component\DependencyInjection\Extension\Extension instead | |||
There was a problem hiding this comment.
We cannot deprecate this class right away in 7.1 because we rely on it in FrameworkBundle and others.
Making it first internal then deprecate in 8.1 provides a smooth upgrade path.
There was a problem hiding this comment.
Actually, if it is already a no-op, FrameworkBundle could stop registering it.
There was a problem hiding this comment.
if you mean AddAnnotatedClassesToCachePass, that's done in this PR
There was a problem hiding this comment.
ah, I see. This is about the base class then.
Marking as @internal first which removes it from our BC policy before deprecating it only in 8.1 looks weird to me. If we don't deprecate it, we might keep it as non-internal.
There was a problem hiding this comment.
it's @internal since, which means its deprecated to use, but we signals to us we won't remove it in 8.0 for BC reasons
There was a problem hiding this comment.
but @internal since 7.1 would become @internal in 8.0, which can be removed.
There was a problem hiding this comment.
can but doesn't have to, while deprecated means it should be removed
I'm looking for a smoother plan
javiereguiluz
added
the
❄️ Feature Freeze
nicolas-grekas
force-pushed
the
hk-deprec-annotated-classes
branch
from
599867d
to
926be8f
Compare
|
Quick rebase needed |
…ode infrastructure
fabpot
force-pushed
the
hk-deprec-annotated-classes
branch
from
926be8f
to
ef95928
Compare
|
Thank you @nicolas-grekas. |
…#132) `Symfony\Component\HttpKernel\DependencyInjection\Extension` is deprecated since Symfony 7.1 by symfony/symfony#53801
These code paths are already no-ops in 7.1 since we don't support annotations anymore.