Issue #5307: HTML regexp when match is false #5382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,6 +74,11 @@ public function getHtmlPattern() | |||
| */ | |||
| private function getNonDelimitedPattern() | |||
| { | |||
| // If match = false, pattern should not be added to HTML5 validation | |||
| if ( ! $this->match) { | |||
There was a problem hiding this comment.
Could you please remove the spaces around the "!"? (see coding standards)
|
👍 once the CS issue is fixed. |
|
Could swear that was the CS in PSR-1 or 2, anyway, fixed. |
|
Can you squash your commits before I merge? Thanks. |
When match is false the html5 validation regexp should be either inverted or not added. Since we are in RC added a fix where this is not added, but marked a @todo so that this can be revisited and we try to inverse the regexp instead.
|
@fabpot done. |
fabpot
added a commit
that referenced
this pull request
Aug 30, 2012
Commits ------- 7503ec9 Issue #5307: HTML regexp when match is false Discussion ---------- Issue #5307: HTML regexp when match is false When match is false the html5 validation regexp should be either inverted or not added. Since we are in RC added a fix where this is not added, but marked a @todo so that this can be revisited and we try to inverse the regexp instead. Discussed in #5307. --------------------------------------------------------------------------- by bschussek at 2012-08-30T08:40:06Z :+1: once the CS issue is fixed. --------------------------------------------------------------------------- by rdohms at 2012-08-30T09:23:57Z Could swear that was the CS in PSR-1 or 2, anyway, fixed. --------------------------------------------------------------------------- by fabpot at 2012-08-30T09:26:07Z Can you squash your commits before I merge? Thanks. --------------------------------------------------------------------------- by rdohms at 2012-08-30T09:54:26Z @fabpot done.
Nyholm
added a commit
that referenced
this pull request
Apr 1, 2021
…attern() phpDoc (guilliamxavier) This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Delete obsolete statement in Regex::getHtmlPattern() phpDoc | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #12235 | License | MIT | Doc PR | The original issue was #5307 (`match=false` not handled in `getHtmlPattern()`). Then #5382 patched it to return null (rather than an incorrect result) and inserted a statement and a "todo" in the phpDoc. Later (but still years ago) #12235 properly implemented pattern inversion, but only removed the "todo"; this PR removes the statement. Commits ------- 3bdf8d7 [Validator] Delete obsolete statement in Regex::getHtmlPattern() phpDoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When match is false the html5 validation regexp should be either inverted or not added.
Since we are in RC added a fix where this is not added, but marked a @todo so that this
can be revisited and we try to inverse the regexp instead.
Discussed in #5307.