Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clock] Add get/setMicroseconds() #53942

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

Polyfilling php/php-src#12557

@stof
Copy link
Member

stof commented Feb 14, 2024

One question here: how confident are we that the new PHP method won't be changed between now and the PHP 8.4 feature freeze in a way that would break our child method ? Symfony 7.1 will be released 6 months before PHP 8.4.
If we are not 100% confident, we should delay that to Symfony 7.2 to avoid making it impossible to make the component compatible with PHP 8.4 without BC break.

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Feb 14, 2024

The only thing that could change is the return type of the native methods, which we already set (they're tentative-return-types in the engine for now). I'm 99.9% confident this is going to be compatible with 8.4 :)

@OskarStark
Copy link
Contributor

Just in case would it be possible to mark the methods experimental?

@fabpot
Copy link
Member

fabpot commented Feb 23, 2024

Thank you @nicolas-grekas.

@fabpot fabpot merged commit e9c4a6c into symfony:7.1 Feb 23, 2024
7 of 9 checks passed
@fabpot fabpot deleted the clock-ms branch February 23, 2024 07:03
@marc-mabe
Copy link
Contributor

FYI php/php-src#13486 Not sure it it goes through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants