[HttpFoundation] Allow array style callable setting for Request setFactory method

[jan-simbera]

Q	A
Branch?	7.0
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #54321
License	MIT

Allowing to use the array notation for callback for the setFactory static method of the request.

Unit test added to confirm bug/fixing the bug.

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[derrabus]

Thank you. Please find a meaningful title for your PR. We compose our changelog out of those titles.

[derrabus]

We usually use a ternary expression when resolving this kind of union.

Suggested change

	if(null === $callable) {
	self::$requestFactory = null;
	return;
	}
	self::$requestFactory = $callable(...);
	if(null === $callable) {
	self::$requestFactory = null;
	return;
	}
	self::$requestFactory = null === $callable ? null : $callable(...);

[jan-simbera]

Fixed.

[derrabus]

Good catch, thanks @jan-simbera.