-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mailer] [Resend] Add Resend webhook signature verification #54525
[Mailer] [Resend] Add Resend webhook signature verification #54525
Conversation
3881e5e
to
eede9c5
Compare
Unrelated tests failures |
src/Symfony/Component/Mailer/Bridge/Resend/Webhook/ResendRequestParser.php
Outdated
Show resolved
Hide resolved
9d8357b
to
e951137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you still waiting for more test payloads?
src/Symfony/Component/Mailer/Bridge/Resend/Webhook/ResendRequestParser.php
Show resolved
Hide resolved
@fabpot I was waiting for this first one, I'm quite confident about this one and the signature verification code (I get it from the official Resend PHP SDK). Can we merge as it is, and add more webhook tests later if needed? |
e951137
to
8daa804
Compare
Thank you @welcoMattic. |
Follow up of #53554. At this time I missed webhook signature verification. To complete the Bridge before 7.1 release, here it is!
I plan to add more webhook payloads in test, I asked Resend to send me example, because some are tough to reproduce.