[Mailer] [Resend] Add Resend webhook signature verification #54525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
added
the
❄️ Feature Freeze
carsonbot
changed the title
carsonbot
changed the title
welcoMattic
force-pushed
the
mailer-resend-webhook-verification
branch
from
3881e5e
to
eede9c5
Compare
|
Unrelated tests failures |
norkunas
reviewed
Apr 8, 2024
src/Symfony/Component/Mailer/Bridge/Resend/Webhook/ResendRequestParser.php
Outdated
Show resolved
Hide resolved
welcoMattic
force-pushed
the
mailer-resend-webhook-verification
branch
from
9d8357b
to
e951137
Compare
welcoMattic
changed the title
fabpot
reviewed
Apr 17, 2024
src/Symfony/Component/Mailer/Bridge/Resend/Webhook/ResendRequestParser.php
Show resolved
Hide resolved
|
@fabpot I was waiting for this first one, I'm quite confident about this one and the signature verification code (I get it from the official Resend PHP SDK). Can we merge as it is, and add more webhook tests later if needed? |
fabpot
approved these changes
Apr 17, 2024
carsonbot
changed the title
fabpot
force-pushed
the
mailer-resend-webhook-verification
branch
from
e951137
to
8daa804
Compare
|
Thank you @welcoMattic. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #53554. At this time I missed webhook signature verification. To complete the Bridge before 7.1 release, here it is!
I plan to add more webhook payloads in test, I asked Resend to send me example, because some are tough to reproduce.