[Messenger] Don't drop stamps when message validation fails #54842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valtzu
force-pushed
the
fix-messenger-validation-stamps
branch
from
54ad10f
to
eafba2e
Compare
chalasr
reviewed
May 4, 2024
src/Symfony/Component/Messenger/Exception/EnvelopeAwareExceptionInterface.php
Show resolved
Hide resolved
chalasr
approved these changes
May 4, 2024
fabpot
approved these changes
May 7, 2024
fabpot
force-pushed
the
fix-messenger-validation-stamps
branch
from
f51aa95
to
fed32dc
Compare
|
Thank you @valtzu. |
|
@valtzu I've merged this PR up to 7.1. Can you submit a PR on 7.1 to remove the |
fabpot
added a commit
that referenced
this pull request
May 7, 2024
…e` internal (valtzu) This PR was merged into the 7.1 branch. Discussion ---------- [Messenger] Don't mark `EnvelopeAwareExceptionInterface` internal | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT As discussed [here](#54842 (comment)), let's expose `EnvelopeAwareExceptionInterface` to allow custom Messenger middlewares throw a custom exception without causing stamps from previous middlewares being dropped. Commits ------- 7713fd1 Don't mark EnvelopeAwareExceptionInterface internal
symfony-splitter
pushed a commit
to symfony/messenger
that referenced
this pull request
May 7, 2024
…e` internal (valtzu) This PR was merged into the 7.1 branch. Discussion ---------- [Messenger] Don't mark `EnvelopeAwareExceptionInterface` internal | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT As discussed [here](symfony/symfony#54842 (comment)), let's expose `EnvelopeAwareExceptionInterface` to allow custom Messenger middlewares throw a custom exception without causing stamps from previous middlewares being dropped. Commits ------- 7713fd17f5 Don't mark EnvelopeAwareExceptionInterface internal
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidationMiddlewarehas the same issue asDispatchAfterCurrentBusMiddlewaredid before the fix: if message validation fails, stamps added by previous middlewares in the stack are dropped. What this means in practice is:bin/console messenger:consume --bus=externalreceives a message andAddBusNameStampMiddlewareadds theBusNameStampso that in case of failure it would be routed to a correct busBusNameStampis sent to failure queuebin/console messenger:failed:retry, the message is dispatched on wrong bus (the default one)This has really bad implications if you handle the message differently depending on which bus it is received.
Some refactoring was done to reduce duplication, similar to
WrappedExceptionsTrait/WrappedExceptionsInterface.