[FrameworkBundle] made sure that the debug event dispatcher is used everywhere #9068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Sep 18, 2013
fabpot
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #6686, #7673 |
| License | MIT |
| Doc PR | n/a |
fabpot
added a commit
that referenced
this pull request
Sep 19, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [FrameworkBundle] made sure that the debug event dispatcher is used everywhere | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6686, #7673 | License | MIT | Doc PR | n/a Commits ------- f65a526 [FrameworkBundle] made sure that the debug event dispatcher is used everywhere
fabpot
added a commit
that referenced
this pull request
Sep 23, 2013
fabpot
added a commit
that referenced
this pull request
Sep 23, 2013
* 2.2: Revert "merged branch fabpot/event-dispatcher-debug (PR #9068)" Conflicts: src/Symfony/Component/HttpKernel/DependencyInjection/RegisterListenersPass.php src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RegisterListenersPassTest.php
fabpot
added a commit
that referenced
this pull request
Sep 23, 2013
* 2.3: Revert "merged branch fabpot/event-dispatcher-debug (PR #9068)"
fabpot
added a commit
that referenced
this pull request
Oct 28, 2013
… is used everywhere (fabpot) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] made sure that the debug event dispatcher is used everywhere | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6686, #7673 | License | MIT | Doc PR | n/a The removal of the Profiler dependency on the TraceableEventDispatcher (#9170) allows to remerge the patch from #9068 that fixes #6686. This PR also cleans up how profiles are stored. A Profile is now always stored only once. The fix will only be available on 2.4+ as the changes are too deep to be backported to 2.2 and 2.3. Commits ------- 1e1835e [FrameworkBundle] made sure that the debug event dispatcher is used everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.