[2.2][Propel1] re-factor Propel1 ModelChoiceList #9469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests pass on my local machine. |
| use Symfony\Bridge\Propel1\Tests\Fixtures\ReadOnlyItem; | ||
| use Symfony\Bridge\Propel1\Tests\Propel1TestCase; | ||
|
|
There was a problem hiding this comment.
Please remove the extra empty lines
* add BaseModelChoiceListTest ensuring compatibility * fix keys and order are preserved * fix lazy-load to use filters of initial query
|
👍 it fixes the issue with many to many form types on symfony 2.3.7 |
fabpot
added a commit
that referenced
this pull request
Nov 14, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [2.2][Propel1] re-factor Propel1 ModelChoiceList | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | fixes propelorm/Propel#789 | License | MIT replaces #9458 Commits ------- 613b5f6 re-factor Propel1 ModelChoiceList
fabpot
added a commit
that referenced
this pull request
Nov 16, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [2.2] Fixed ModelChoiceList tests in Propel1 bridge Tests on 2.2 are broken since #9469 was merged. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 1e2d14e Fixed ModelChoiceList tests in Propel1 bridge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #9458