Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] optimized ExpressionVoter #9563

Merged
merged 1 commit into from
Nov 22, 2013
Merged

[Security] optimized ExpressionVoter #9563

merged 1 commit into from
Nov 22, 2013

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Nov 21, 2013

No description provided.

@stof
Copy link
Member

stof commented Nov 21, 2013

This seems legitimate.
The drawback is that it computes variables several times if you have several attributes in the matching. But to be honest, I neevr saw any piece of code passing several attributes to the authorization manager (and it is even less likely to pass several expressions). So I don't think it is an issue.

However, Travis tells me that the functional tests of the SecurityBundle are broken.

@fabpot
Copy link
Member Author

fabpot commented Nov 21, 2013

@stof: it now computes the variables only once.

fabpot added a commit that referenced this pull request Nov 22, 2013
@fabpot
minor #9563 [Security] optimized ExpressionVoter (fabpot)
f00146f 
This PR was merged into the master branch.

Discussion
----------

[Security] optimized ExpressionVoter

Commits
-------

a8c74d1 [Security] optimized ExpressionVoter
@fabpot fabpot merged commit a8c74d1 into master Nov 22, 2013
@fabpot fabpot deleted the expression-voter-optim branch November 22, 2013 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabpot @stof