[Security] Typos in Security's ExpressionLanguage #9597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…\Authorization\ExpressionLanguage. Changed some functions available in ExpressionLanguage: is_authenticated() updated to account for null tokens (firewall security set to false). Fix typos in is_fully_authenticated(). is_fully_authenticated() should not negate $trust_resolver->isFullFledged(). is_remember_me() should also not negate the result of $trust_resolver->isRememberMe().
|
thanks for you contribution ✨ you should respect coding standard in your test file (4 spaces indentation) |
|
Sorry about the indentation. I'm not using my work IDE. I just fixed the indentation in the test. The other file looks ok. Thanks ! |
| @@ -31,21 +31,21 @@ protected function registerFunctions() | |||
| }); | |||
|
|
|||
| $this->register('is_authenticated', function () { | |||
| return '!$trust_resolver->isAnonymous($token)'; | |||
| return '$token && !$trust_resolver->isAnonymous($token)'; | |||
There was a problem hiding this comment.
why $token && is needed? AFAIK, the check is already done in isAnonymous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the ExpressionLanguage and added the tests. It looks ok to me, but please, take a close look (some people will depend on this working right, including me :D ).
Thanks !