[Dependencyinjection] Fixed handling of inlined references in the AnalyzeServiceReferencesPass #9829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyzeServiceReferencesPass In some cases `InlineServiceDefinitionsPass` replaces a Reference with a service Definition. In such scenarios `AnalyzeServiceReferencesPass` was falling into an infinite loop.
|
Closing in favor of #9885 where we solve the root cause. |
fabpot
added a commit
that referenced
this pull request
Dec 29, 2013
…in the AnalyzeServiceReferencesPass (fabpot) This PR was merged into the 2.3 branch. Discussion ---------- [Dependencyinjection] Fixed handling of inlined references in the AnalyzeServiceReferencesPass | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8299, #9829 | License | MIT | Doc PR | n/a Hopefully a better fix for #9829 (ping @jakzal). Unit tests coming soon. In some cases `InlineServiceDefinitionsPass` replaces a Reference with a service Definition. In such scenarios `AnalyzeServiceReferencesPass` was falling into an infinite loop. Commits ------- d650295 [DependencyInjection] fixed InlineServiceDefinitionsPass to not inline a service if it's part of the current definition (to avoid an infinite loop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
InlineServiceDefinitionsPassreplaces a Reference with a service Definition. In such scenariosAnalyzeServiceReferencesPasswas falling into an infinite loop.