Propel1 exception message #9933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (empty($this->class)) { | ||
| throw new MissingOptionsException('The "class" parameter is empty, you should provide the model class'); | ||
| } | ||
| throw new InvalidOptionsException(sprintf('The query class "%s" is not found, you should provided the FQCN of the model class', $queryClass)); |
|
@jaugustin wouldn't this be picked up by the error handler form the Debug component? |
|
@jakzal Yes that was the goal, and I just tested it now ;) |
|
I mean, Debug component should pick up this kind of error even if you don't throw an exception (and it should propose how to fix the class name). |
|
@jakzal if you didn't set the |
fabpot
added a commit
that referenced
this pull request
Jan 6, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Propel1 exception message | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9932 | License | MIT | Doc PR | none This add exception message for `ModelChoiceList` and `ModelType` when `class` parameter is not provided or invalid Commits ------- 047492f [Propel1Bridge][ModelChoiceList] add exception message for invalid classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add exception message for
ModelChoiceListandModelTypewhenclassparameter is not provided or invalid