New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propel1 exception message #9933

Merged
merged 1 commit into from Jan 6, 2014

Conversation

Projects
None yet
3 participants
@jaugustin
Contributor

jaugustin commented Jan 2, 2014

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #9932
License MIT
Doc PR none

This add exception message for ModelChoiceList and ModelType when class parameter is not provided or invalid

@jakzal

This comment has been minimized.

Show comment
Hide comment
@jakzal

jakzal Jan 2, 2014

Member

@jaugustin wouldn't this be picked up by the error handler form the Debug component?

Member

jakzal commented Jan 2, 2014

@jaugustin wouldn't this be picked up by the error handler form the Debug component?

@jaugustin

This comment has been minimized.

Show comment
Hide comment
@jaugustin

jaugustin Jan 2, 2014

Contributor

@jakzal Yes that was the goal, and I just tested it now ;)

Contributor

jaugustin commented Jan 2, 2014

@jakzal Yes that was the goal, and I just tested it now ;)

@jakzal

This comment has been minimized.

Show comment
Hide comment
@jakzal

jakzal Jan 2, 2014

Member

I mean, Debug component should pick up this kind of error even if you don't throw an exception (and it should propose how to fix the class name).

Member

jakzal commented Jan 2, 2014

I mean, Debug component should pick up this kind of error even if you don't throw an exception (and it should propose how to fix the class name).

@jaugustin

This comment has been minimized.

Show comment
Hide comment
@jaugustin

jaugustin Jan 5, 2014

Contributor

@jakzal if you didn't set the class parameter the Debug component will tell you about a Query class not found but that didn't make much sens

Contributor

jaugustin commented Jan 5, 2014

@jakzal if you didn't set the class parameter the Debug component will tell you about a Query class not found but that didn't make much sens

fabpot added a commit that referenced this pull request Jan 6, 2014

bug #9933 Propel1 exception message (jaugustin)
This PR was merged into the 2.3 branch.

Discussion
----------

Propel1 exception message

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9932
| License       | MIT
| Doc PR        | none

This add exception message for `ModelChoiceList` and `ModelType` when `class` parameter is not provided or invalid

Commits
-------

047492f [Propel1Bridge][ModelChoiceList] add exception message for invalid classes

@fabpot fabpot merged commit 047492f into symfony:2.3 Jan 6, 2014

1 check passed

default Success: Travis, fabbot
Details

@jaugustin jaugustin deleted the jaugustin:propel1-exception-message branch Jan 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment