Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swup, main element animation #58

Closed
disjfa opened this issue Feb 5, 2021 · 2 comments
Closed

Swup, main element animation #58

disjfa opened this issue Feb 5, 2021 · 2 comments
Labels

Comments

@disjfa
Copy link

disjfa commented Feb 5, 2021

The setup:
I want to setup my site with my own id names, so i have set up the containers data-containers="#base #nav"

The problem:
Now the swup animation does not work anymore. This is because the animation plugins also use an option on them to name the main element of the animation({{ mainElement: '#swup' }). See documentation.

https://swup.js.org/themes/fade-theme
https://github.com/swup/fade-theme/blob/master/src/index.js#L11

The solution
Add a data-main-element attribute so we can also setup the main elements for the animations.

@optior
Copy link
Contributor

optior commented Mar 7, 2021

#20 should solve this issue.

@carsonbot
Copy link

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants