Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource creation doesn't show XML output options #1254

Closed
makenosound opened this issue Apr 17, 2012 · 4 comments
Closed

Datasource creation doesn't show XML output options #1254

makenosound opened this issue Apr 17, 2012 · 4 comments
Milestone

Comments

@makenosound
Copy link
Contributor

If you're creating a datasource for the first section (e.g., in the default workspace for "Articles"), the XML output values aren't populated.

Works once you change the "Source" to something else and then back again.

@proyb2
Copy link

proyb2 commented Apr 17, 2012

Source (drop-down list), yup, I can confirm the same issue on my side.

I'm suggest, it should show as "Select a source" instead of "Articles" by default.

@brendo
Copy link
Member

brendo commented Apr 17, 2012

This seems to be related to the namespacing of admin events. The #ds-context select box has a change.admin listener/trigger. Removing .admin from Line 535 resolves the issue but from what I can see it should be working regardless.

/cc @nilshoerrmann

@nilshoerrmann
Copy link
Contributor

I'm sorry, that's my fault: I forgot to update two old event handlers as it seems.

Line 465 in admin.js should be:

contents.find('input[name="fields[name]"]').on('change.admin', function() {

and line 507 should be:

$('#ds-context').on('change.admin', function() {

I'll send a pull request with these fixes.

@brendo
Copy link
Member

brendo commented Apr 17, 2012

Ah, no worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants