Remove EEmbeddedEnumClassConstSpotterRule, as configurable and quite …

…complex (#64)
symplify · Aug 7, 2023 · ab93db5 · ab93db5
1 parent 18b34b9
commit ab93db5
Show file tree

Hide file tree

Showing 14 changed files with 1 addition and 470 deletions.
diff --git a/config/services/services.neon b/config/services/services.neon
@@ -13,17 +13,14 @@ services:
     - Symplify\PHPStanRules\Composer\ClassNamespaceMatcher
     - Symplify\PHPStanRules\Composer\ComposerAutoloadResolver
     - Symplify\PHPStanRules\Composer\Psr4PathValidator
-    - Symplify\PHPStanRules\Enum\EnumConstantAnalyzer
     - Symplify\PHPStanRules\Formatter\RequiredWithMessageFormatter
     - Symplify\PHPStanRules\Location\DirectoryChecker
     - Symplify\PHPStanRules\Matcher\PositionMatcher
-    - Symplify\PHPStanRules\Matcher\SharedNamePrefixMatcher
     - Symplify\PHPStanRules\Naming\BoolishNameAnalyser
     - Symplify\PHPStanRules\Naming\ClassToSuffixResolver
     - Symplify\PHPStanRules\NodeAnalyzer\ArrayAnalyzer
     - Symplify\PHPStanRules\NodeAnalyzer\AttributeFinder
     - Symplify\PHPStanRules\NodeAnalyzer\CacheIfAnalyzer
-    - Symplify\PHPStanRules\NodeAnalyzer\ClassAnalyzer
     - Symplify\PHPStanRules\NodeAnalyzer\EnumAnalyzer
     - Symplify\PHPStanRules\NodeAnalyzer\IfElseBranchAnalyzer
     - Symplify\PHPStanRules\NodeAnalyzer\IfResemblingMatchAnalyzer

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 78 Rules Overview
+# 77 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -316,56 +316,6 @@ class SomeCommand extends Command
 
 <br>
 
-## EmbeddedEnumClassConstSpotterRule
-
-Constants "%s" should be extract to standalone enum class
-
-:wrench: **configure it!**
-
-- class: [`Symplify\PHPStanRules\Rules\Enum\EmbeddedEnumClassConstSpotterRule`](../src/Rules/Enum/EmbeddedEnumClassConstSpotterRule.php)
-
-```yaml
-services:
-    -
-        class: Symplify\PHPStanRules\Rules\Enum\EmbeddedEnumClassConstSpotterRule
-        tags: [phpstan.rules.rule]
-        arguments:
-            parentTypes:
-                - AbstractObject
-```
-
-↓
-
-```php
-class SomeProduct extends AbstractObject
-{
-    public const STATUS_ENABLED = 1;
-
-    public const STATUS_DISABLED = 0;
-}
-```
-
-:x:
-
-<br>
-
-```php
-class SomeProduct extends AbstractObject
-{
-}
-
-class SomeStatus
-{
-    public const ENABLED = 1;
-
-    public const DISABLED = 0;
-}
-```
-
-:+1:
-
-<br>
-
 ## ExclusiveNamespaceRule
 
 Exclusive namespace can only contain classes of specific type, nothing else

diff --git a/src/Enum/EnumConstantAnalyzer.php b/src/Enum/EnumConstantAnalyzer.php
diff --git a/src/Matcher/SharedNamePrefixMatcher.php b/src/Matcher/SharedNamePrefixMatcher.php
diff --git a/src/NodeAnalyzer/ClassAnalyzer.php b/src/NodeAnalyzer/ClassAnalyzer.php
diff --git a/src/Rules/Enum/EmbeddedEnumClassConstSpotterRule.php b/src/Rules/Enum/EmbeddedEnumClassConstSpotterRule.php