Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

[ECS] allow easy-coding-standard.yml #565

Closed
TomasVotruba opened this issue Jan 9, 2018 · 11 comments · Fixed by #651
Closed

[ECS] allow easy-coding-standard.yml #565

TomasVotruba opened this issue Jan 9, 2018 · 11 comments · Fixed by #651

Comments

@TomasVotruba
Copy link
Member

Allow easy-coding-standard.yml for those, who preffer yml and don't want Neon Plugin + autocomplete

@OndraM
Copy link
Contributor

OndraM commented Jan 29, 2018

Hi Tomas,
I respect your choice of the configuration file format, but wouldn't you reconsider adding this feature as an option?

I was just considering using ECS to define our codestyle, but for us, neon format is no-go - we don't want yet another format, which will be used for codestyle config only, while everything else we use is configured by yaml (symfony), json (composer, npm, ...) or XML (PHPUnit, PHPCS).

What is your opinion?

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jan 30, 2018

Hi Ondra,

thanks for reaching out. I was thinking about this more and more while presenting ECS to Symfony world.
After few discussions, I came to conclusing having an option is nice to have. So why not? :)

I don't want to implement it myself, but if anyone would take this issue to solve, it would require to add yaml/neon differentiation to AppKernel, where .neon is default.

And note to README of course.

@TomasVotruba TomasVotruba reopened this Jan 30, 2018
@TomasVotruba TomasVotruba changed the title [ECS] allow .yml if easy to extend [ECS] allow easy-coding-standard.yml Feb 20, 2018
@TomasVotruba
Copy link
Member Author

TomasVotruba commented Mar 7, 2018

@OndraM I'm thinking of this again. I'm missing one last thing to make this happen.

As I'm not using Symfony in whole application often, I don't know how to achieve class autocomplete in .yml files. I've seen that Symfony Plugin can autocomplete types based on containers or something like that. But that's not it, I need all classes.

But I need this in .yml file:

jjeje

Any ideas?

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Mar 7, 2018

@enumag @mssimi @grogy @greg0ire Do you know about solution to comment above?

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Mar 7, 2018

Moving further... so Plugin needs to be enabled per project manualy ✔️

Autocomplete then starts working, but only for the old Symfony 2.x style, not just the class 🚫

not-yet

It still doesn't work for other sections then services, like checkers, but that could be worked on a bit.

@TomasVotruba
Copy link
Member Author

I asked for this feature at Symfony Plugin: Haehnchen/idea-php-symfony2-plugin#1153

@mssimi
Copy link

mssimi commented Mar 7, 2018

I don't have class autocomplete in yml either and I am not even sure what should be App Directory(Symfony plugin config) for flex.

@enumag
Copy link
Member

enumag commented Mar 7, 2018

Sadly yaml autocompletion for classes is unreliable in many cases. I don't know any solution.

@foxycode
Copy link

foxycode commented Mar 7, 2018

What about not adding yaml to ECS but reather add neon to Symfony and lobbing for it as default format? :)

@TomasVotruba
Copy link
Member Author

@foxycode Go for it ;) I'll resolve this issue in the meantime by #651

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Mar 26, 2018

I found a way for service autocomplete in Yaml to work!


So simple 🤦‍♂️ 🌴

@deprecated-packages deprecated-packages locked as resolved and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
5 participants