Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment about files that are added or deleted #77

Merged
merged 26 commits into from
Feb 18, 2020
Merged

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Feb 14, 2020

#75

For now it just comments. But we could easily add functionality where someone with push access has to @mention the bot and whitelist files.

This is what this looks like asmeurer/GitHub-Issues-Test#44 (comment)

@asmeurer asmeurer changed the title Added deleted Comment about files that are added or deleted Feb 14, 2020
@asmeurer
Copy link
Member Author

I will need to fix the webapp tests for this, but I want to get feedback if it is a good idea first.

@asmeurer asmeurer temporarily deployed to sympy-bot-testing February 17, 2020 20:08 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing February 17, 2020 20:14 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing February 17, 2020 20:15 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing February 17, 2020 20:19 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing February 17, 2020 20:21 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing February 17, 2020 20:27 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing February 17, 2020 23:54 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing February 18, 2020 00:51 Inactive
@asmeurer
Copy link
Member Author

This is ready to go for a basic test run. This is what the comments would look like asmeurer/GitHub-Issues-Test#44 (comment). For now, it's purely informational. It doesn't currently set any failing status if there are added or deleted files. It also automatically deletes the comment if you force push and remove the offending commits.

I would suggest merging this as-is and getting feedback from the community on if it's a good idea and how it can be improved.

@oscarbenjamin
Copy link
Contributor

Yeah, looks good to me. Let's see how it works out in practice.

@oscarbenjamin oscarbenjamin merged commit 61697bd into master Feb 18, 2020
@asmeurer asmeurer deleted the added-deleted branch February 19, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants