-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment about files that are added or deleted #77
Conversation
I will need to fix the webapp tests for this, but I want to get feedback if it is a good idea first. |
It messes up emacs.
This is ready to go for a basic test run. This is what the comments would look like asmeurer/GitHub-Issues-Test#44 (comment). For now, it's purely informational. It doesn't currently set any failing status if there are added or deleted files. It also automatically deletes the comment if you force push and remove the offending commits. I would suggest merging this as-is and getting feedback from the community on if it's a good idea and how it can be improved. |
Yeah, looks good to me. Let's see how it works out in practice. |
#75
For now it just comments. But we could easily add functionality where someone with push access has to @mention the bot and whitelist files.
This is what this looks like asmeurer/GitHub-Issues-Test#44 (comment)