WIP: ELLIPTIC CURVE #18680
WIP: ELLIPTIC CURVE #18680
Conversation
🟠Hi, I am the SymPy bot (v151). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
|
✅ Hi, I am the SymPy bot (v151). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed. |
|
You should preserve the original commits in #2449. After fetching the PR, you should only add new commits to the same branch. |
|
could you tell me how to fetch that pr. |
| from .residue_ntheory import sqrt_mod | ||
|
|
||
|
|
||
| class EllipticCurve(): |
| The default domain is ``QQ``. If no coefficient ``a1``, ``a2``, ``a3``, | ||
| it create curve as following form. | ||
| `y^{2} = x^{3} + a_{4} x + a_{6}` | ||
| Examples |
There was a problem hiding this comment.
An empty line is needed here.
| `y^{2} = x^{3} + a_{4} x + a_{6}` | ||
| Examples | ||
| ======== | ||
| References |
| [3] G. Hardy, E. Wright "An Introduction to the Theory of Numbers" Sixth Edition | ||
| """ | ||
|
|
||
| def __init__(self, a4, a6, a1=0, a2=0, a3=0, domain=QQ): |
There was a problem hiding this comment.
Generally, in SymPy, __new__ is used as a constructor.
| elif isinstance(self._domain, RationalField): | ||
| self._rank = None | ||
|
|
||
| def __call__(self, x, y, z=1): |
| def minimal(self): | ||
| """ | ||
| Return minimal Weierstrass equation. | ||
| Examples |
There was a problem hiding this comment.
An empty line is needed here.
+1
| Return minimal Weierstrass equation. | ||
| Examples | ||
| ======== | ||
| >>> from sympy.ntheory.ec import EllipticCurve |
|
I think that |
| i += 1 | ||
| if p.z == 0: | ||
| return i | ||
| return oo |
There was a problem hiding this comment.
A new line is needed at the end.
revives #2449