Derivatives of indexed objects #11144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjodah @moorepants @jcrist @asmeurer What do you think? This partially includes stuff from the PR by @joshburkart . Unlike in @joshburkart 's PR, code printers have not been changed (this may be done in the future). Support for derivatives of indexed objects has been added. Sum objects are also supported. |
|
Excellent! +1 |
|
I would like to merge this as soon as possible. Are there objections? |
|
If no objections arise, I'll merge this in one week. |
Closed
6 tasks
| if symbol_set.difference(expr.free_symbols): | ||
| from sympy import IndexedBase | ||
| symbol_set = set(sc[0].base if sc[0].is_Indexed else sc[0] for sc in variable_count if sc[0].is_Symbol) | ||
| if symbol_set.difference(expr.free_symbols).difference(expr.atoms(IndexedBase)): |
There was a problem hiding this comment.
@asmeurer this was the trick to allow A[i].diff(A[j]). This is an optimization, it checks whether the deriving varible is contained in the expression, otherwise return zero (i.e. deriving a constant).
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides derivatives for indexed objects.
It is roughly based on #9314 , except that