-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update symengine tested version and fix deprecation warnings #12809
Conversation
.travis.yml
Outdated
conda config --add channels symengine; | ||
conda install python-symengine=0.2.0; | ||
conda config --add channels symengine/label/dev; | ||
conda install python-symengine=0.3.0.rc0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a release candidate. There'll be a new release within a week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be python-symengine=0.3* ? So that it isn't fixed to an rc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'll fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the *. Conda adds it automatically if you use a single =
.
@asmeurer, is it okay to merge as it is now before the symengine release (will happen this weekend)? I'd like to get this into the new release of sympy. |
Can you PR this against the 1.1 branch? |
Changed the base branch to 1.1 |
Oh I forgot you can change the base without closing the PR. |
Hmm, there are tests failing. Is the 1.1 branch passing tests? EDIT: 1.1 is failing |
Test failures should be fixed in #12833. Merging this anyway because I don't want to wait for Travis. |
No description provided.