Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symengine tested version and fix deprecation warnings #12809

Merged
merged 3 commits into from
Jun 30, 2017

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jun 26, 2017

No description provided.

.travis.yml Outdated
conda config --add channels symengine;
conda install python-symengine=0.2.0;
conda config --add channels symengine/label/dev;
conda install python-symengine=0.3.0.rc0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a release candidate. There'll be a new release within a week.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be python-symengine=0.3* ? So that it isn't fixed to an rc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'll fix that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the *. Conda adds it automatically if you use a single =.

@isuruf
Copy link
Member Author

isuruf commented Jun 29, 2017

@asmeurer, is it okay to merge as it is now before the symengine release (will happen this weekend)? I'd like to get this into the new release of sympy.

@isuruf isuruf requested a review from asmeurer June 30, 2017 03:40
@asmeurer
Copy link
Member

Can you PR this against the 1.1 branch?

@isuruf isuruf changed the base branch from master to 1.1 June 30, 2017 03:45
@isuruf
Copy link
Member Author

isuruf commented Jun 30, 2017

Changed the base branch to 1.1

@asmeurer
Copy link
Member

Oh I forgot you can change the base without closing the PR.

@isuruf isuruf added this to the SymPy 1.1 milestone Jun 30, 2017
@isuruf
Copy link
Member Author

isuruf commented Jun 30, 2017

Hmm, there are tests failing. Is the 1.1 branch passing tests?

EDIT: 1.1 is failing

@asmeurer
Copy link
Member

Test failures should be fixed in #12833. Merging this anyway because I don't want to wait for Travis.

@asmeurer asmeurer merged commit abad1c5 into sympy:1.1 Jun 30, 2017
@isuruf isuruf deleted the symengine branch July 1, 2017 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants