-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement to the beam sphinx docs #15310
Conversation
✅ Hi, I am the SymPy bot (v134). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.4. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
2130335
to
b887c84
Compare
The matplolib plot directive seems to create an output on Travis that I don't see locally. I thought the trailing semicolon would suppress that:
|
@asmeurer Curious if you are fine adding the matplotlib sphinx directive extension so that we can show plots in the sympy docs? (before I do more work on this) |
I am getting errors locally. Just writing the
|
- More tutorial style with explanations. - Show plots with matplotlib sphinx directive.
b887c84
to
cb169b7
Compare
This is ready for a review. Tests seem to be passing. |
@jashan498 Can you review? |
Shouldn't deflection and slope curves also be added for truncated polynomial load example? |
Yes, more can always be added. I think that it is sufficient as is to demonstrate that the loading work correctly (from fixes in #15304). All of the examples can be improved. Just wanted to get matplotlib extension working and have at least one example showing that off. Gonna merge for now and open issues for further improvements. |
This looks nice. I would suggest replacing the ASCII art with an SVG image (it shouldn't be too hard to recreate in Inkscape). |
\\\\|V V V V V V V V V | | ||
\\\\|________________|_______________V | ||
\\\\| | | | ||
\\\\o - - - - - - - -⭯ 50 kN-m - - - | - - -> x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth noting that this ⭯ character doesn't render for me on my phone (it just comes out as a blank space).
Yes, it would be nice to have SVG diagrams. We can open an issue for that. Drawing them will take some time.
I guess this is a system font thing? Not sure how to know what unicode characters are generally supported. |
References to other Issues or PRs
#15304 needs to be merged before this one.
Brief description of what is fixed or changed
I added the matplotlib sphinx directive to the sphinx config file so that we can use the plot directive to display plots from sympy.plot() or matplotlib directly. I made use of it to improve the first beam bending example. The following screenshot shows the results:
Other comments
Release Notes