Added heuristics kwarg for Limit.doit solving big-oh notation error, added tests

[avishrivastava11]

Added heuristics kwarg for limit.doit solving big-oh notation error, added tests

Fixes #9917
Note : I've used the changes implemented by Sergey Kirpichev in diofant here

Release Notes

• series
  • Added heuristics kwarg for limit.doit
  • Added tests

[sympy-bot]

✅

Hi, I am the SymPy bot (v134). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• series

  • Added heuristics kwarg for limit.doit (#15512 by @avishrivastava11)

  • Added tests (#15512 by @avishrivastava11)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.4.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

Added heuristics `kwarg` for `limit.doit` solving big-oh notation error, added tests

Fixes #9917
Note : I've used the changes implemented by Sergey Kirpichev in diofant [here](https://github.com/diofant/diofant/commit/8b7a103fb4baeefb9efc1241452e22240eb04af0)
#### Release Notes

<!-- BEGIN RELEASE NOTES -->
* series
   * Added heuristics `kwarg` for `limit.doit`
   * Added tests 
<!-- END RELEASE NOTES -->

[normalhuman]

This line, as well as those below it, do not actually test the behavior of Order. Same object on both sides of equality, so equality is assured to hold regardless of what that object is. So it holds in current master branch as well, where both sides return O(n*sin(n)).

Perhaps you meant to test

O(n*sin(n)+1, (n, oo)).expr == n*sin(n) + 1

which would indeed verify that the expression returned by Order constructor is what you expect.

[oscarbenjamin]

Are you still working on this?

[avishrivastava11]

@oscarbenjamin

Are you still working on this?

Forgive me, I was a bit preoccupied with some work. I'm getting onto it.

[oscarbenjamin]

There's no need to be forgiven :). We all have other things to do as well!

I was just asking so it would be clear to anyone else thinking about working on this.

[praneethratna]

This PR can be closed now since issue #9917 has been fixed and tests for it are added in #22373.