New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a method remove_support() in beam module #15951
base: master
Are you sure you want to change the base?
Conversation
removing previously appllied support on the beam.
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
|
…nd improved docstring example
ping @jashan498 @moorepants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good to me. Let's wait for Jason to approve.
I wonder whether this is necessary. The example in the docstring is very long so I can't imagine typing it interactively. If I'm not doing it interactively then I'm doing it in a .py file and I can remove the support by deleting the line that adds the support. That's an API design issue for the beam module though so I will defer to @moorepants. |
@oscarbenjamin I guess |
@jashan498 I have corrected the errors. Could you please have a look. |
@ishanaj Any news on this? |
Sure, I will be resolving the conflicts. |
@ishanaj Any updates? |
Codecov Report
@@ Coverage Diff @@
## master #15951 +/- ##
=============================================
- Coverage 75.666% 75.652% -0.015%
=============================================
Files 647 647
Lines 168517 168536 +19
Branches 39707 39710 +3
=============================================
- Hits 127511 127501 -10
- Misses 35449 35475 +26
- Partials 5557 5560 +3 |
@czgdp1807 I have resolved the conflicts. |
The current
beam
module has a methodapply_support()
which applies a particular support on the beam and corresponding reaction force, reaction moments and boundary conditions are defined according to the type of support.This PR incorporates a method to remove a particular support from the beam.
This would help in modifying any beam, without the need of defining it again in case of any modifications to be done on the beam or any errors made while defining a beam.
Release Notes