Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a method remove_support() in beam module #15951

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ishanaj
Copy link
Contributor

@ishanaj ishanaj commented Feb 9, 2019

The current beam module has a method apply_support() which applies a particular support on the beam and corresponding reaction force, reaction moments and boundary conditions are defined according to the type of support.

This PR incorporates a method to remove a particular support from the beam.
This would help in modifying any beam, without the need of defining it again in case of any modifications to be done on the beam or any errors made while defining a beam.

Release Notes

  • physics.continuum_mechanics
    • added a method to remove previously applied support(s) on the beam.

removing previously appllied support on the beam.
@sympy-bot
Copy link

sympy-bot commented Feb 9, 2019

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • physics.continuum_mechanics
    • added a method to remove previously applied support(s) on the beam. (#15951 by @ishanaj)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

The current `beam` module has a method `apply_support()` which applies a particular support on the beam and corresponding reaction force, reaction moments and boundary conditions are defined according to the type of support.

This PR incorporates a method to remove a particular support from the beam.
This would help in modifying any beam, without the need of defining it again in case of any modifications to be done on the beam or any errors made while defining a beam.

#### Release Notes
<!-- BEGIN RELEASE NOTES -->
- physics.continuum_mechanics
    - added a method to remove previously applied support(s) on the beam.
<!-- END RELEASE NOTES -->

@ishanaj
Copy link
Contributor Author

ishanaj commented Feb 11, 2019

ping @jashan498 @moorepants

Copy link
Member

@jashan498 jashan498 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good to me. Let's wait for Jason to approve.

sympy/physics/continuum_mechanics/beam.py Outdated Show resolved Hide resolved
sympy/physics/continuum_mechanics/beam.py Outdated Show resolved Hide resolved
@Abdullahjavednesar Abdullahjavednesar added the PR: author's turn The PR has been reviewed and the author needs to submit more changes. label Feb 13, 2019
@oscarbenjamin
Copy link
Contributor

I wonder whether this is necessary. The example in the docstring is very long so I can't imagine typing it interactively. If I'm not doing it interactively then I'm doing it in a .py file and I can remove the support by deleting the line that adds the support.

That's an API design issue for the beam module though so I will defer to @moorepants.

@ishanaj
Copy link
Contributor Author

ishanaj commented Mar 11, 2019

@oscarbenjamin I guess remove_support() would have the same use case as remove_load().

@ishanaj
Copy link
Contributor Author

ishanaj commented Mar 22, 2019

@jashan498 I have corrected the errors. Could you please have a look.

@czgdp1807
Copy link
Member

@ishanaj Any news on this?

@ishanaj
Copy link
Contributor Author

ishanaj commented Dec 20, 2019

Sure, I will be resolving the conflicts.

@czgdp1807 czgdp1807 added Please take over and removed PR: author's turn The PR has been reviewed and the author needs to submit more changes. labels Mar 4, 2020
@czgdp1807
Copy link
Member

@ishanaj Any updates?

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #15951 into master will decrease coverage by 0.014%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master    #15951       +/-   ##
=============================================
- Coverage   75.666%   75.652%   -0.015%     
=============================================
  Files          647       647               
  Lines       168517    168536       +19     
  Branches     39707     39710        +3     
=============================================
- Hits        127511    127501       -10     
- Misses       35449     35475       +26     
- Partials      5557      5560        +3     

@ishanaj
Copy link
Contributor Author

ishanaj commented Mar 13, 2020

@czgdp1807 I have resolved the conflicts.
I think it is ready to merge if the feature seems good to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants