Fix bug in ask related to custom AskHandler

[mcpl-sympy]

References to other Issues or PRs

Fixes #18106

Brief description of what is fixed or changed

Added except KeyError: pass condition in ask.

Other comments

This commit fixes bug in passing custom AskHandler as assumption of ask.

Release Notes

• assumptions
  • Improved code in ask function using constructs from cnf module.
  • Fixed bug in ask function: In case of user-defined Predicates it generated KeyError while checking for local_facts. Now falls back to Handlers and satask.

[sympy-bot]

✅

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• assumptions

  • Improved code in ask function using constructs from cnf module. (#18204 by @JSS95 and @mcpl-sympy)

  • Fixed bug in ask function: In case of user-defined Predicates it generated KeyError while checking for local_facts. Now falls back to Handlers and satask. (#18204 by @JSS95 and @mcpl-sympy)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #18106


#### Brief description of what is fixed or changed

Added `except KeyError: pass` condition in `ask`.

#### Other comments

This commit fixes bug in passing custom AskHandler as assumption of `ask`.

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->

* assumptions
    * Improved code in ask function using constructs from cnf module.
    * Fixed bug in ask function: In case of user-defined Predicates it generated KeyError while checking for local_facts. Now falls back to Handlers and satask.

<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

[codecov]

Codecov Report

Merging #18204 into master will increase coverage by 0.032%.
The diff coverage is 83.333%.

@@              Coverage Diff              @@
##            master    #18204       +/-   ##
=============================================
+ Coverage   74.936%   74.968%   +0.032%     
=============================================
  Files          642       642               
  Lines       167128    167122        -6     
  Branches     39331     39324        -7     
=============================================
+ Hits        125240    125289       +49     
+ Misses       36351     36294       -57     
- Partials      5537      5539        +2

[ShubhamKJha]

Looks good to me. Will merge if no one objects.

[ShubhamKJha]

I am merging it now. Thanks for your contribution.