[WIP] Add density and cdf plot functions for random variables #19073

Smit-create · 2020-04-05T11:27:42Z

References to other Issues or PRs

Related to the discussion in #18730, See 18730(comment)

Brief description of what is fixed or changed

Other comments

Finalize the API for plot functions in stats
Add functions to plot density and cdf
Add Documentation and tests

Release Notes

stats
- Added density and cdf plotting functions

sympy-bot · 2020-04-05T11:27:52Z

✅

Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

stats
- Added density and cdf plotting functions (#19073 by @Smit-create)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Related to the discussion in #18730, See [18730(comment)](https://github.com/sympy/sympy/issues/18730#issuecomment-596183566)

#### Brief description of what is fixed or changed


#### Other comments
- [ ] Finalize the API for plot functions in stats
- [ ] Add functions to plot `density` and `cdf`
- [ ] Add Documentation and tests

#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* stats
   * Added `density` and `cdf` plotting functions
<!-- END RELEASE NOTES -->

sylee957 · 2020-04-05T13:14:44Z

Does it support both continuous and discrete?

Smit-create · 2020-04-05T13:37:39Z

Yes, it plots for discrete Rv, but I was wondering If we have something like scatter plot in matplotlib(for plotting for discrete), also, some argument like xlim(presently doesn't work good) which plots only on the required domain?

sylee957 · 2020-04-05T17:49:27Z

I don't think that it gives meaningful result for discrete random variables, but gives a plain axis with nothing plotted.
I don't think that there is any API in sympy for scatter plot or stem plots, so someone should develop the plotting module, but I'm afraid that it can quickly grow out of scope in this PR.

Smit-create · 2020-04-06T05:47:07Z

I don't think that there is any API in sympy for scatter plot

I agree, plotting of discrete RV as continuous lines does not look good. I had expected to create some plots for them as here. But, Currently, I think creating such plots will require refining plotting module. Please share your thoughts on this @czgdp1807

Smit-create · 2020-04-06T05:55:32Z

sympy/plotting/plot.py

@@ -575,7 +575,7 @@ class LineOver1DRangeSeries(Line2DBaseSeries):
    def __init__(self, expr, var_start_end, **kwargs):
        super(LineOver1DRangeSeries, self).__init__()
        self.expr = sympify(expr)
-        self.label = str(self.expr)
+        self.label = kwargs.get('label', None) or str(self.expr)


@sylee957 Should I make this change in a new PR? It involves adding label as an argument in the plot so that we could use them to denote when we use legend to name that line as in matplotlib. Currently, it by default considers label as str(self.expr) . I will look something like this.

I think that labeling a plot manually can be a useful feature.
But you should add tests for ordinary plots to see how this works.

Is the plotting module able to plot a set of functions in the same graph as shown above? Is the public API of plot capable of supporting such stuff?

Yes, this is able to plot many functions in the same graph. Seeing this as a useful feature, I made a change in the plotting module. But, I think, I should open a new PR for this as it involves a change in public API of plot. Also, I think the current plot is unable to plot discrete graphs as we have scatter plot in matplotlib which is required for plotting discrete RV.

czgdp1807 · 2020-04-06T08:20:39Z

This PR creates a wrapper for plotting module to make things easy. So probably, making changes to plotting module should be restricted here.

czgdp1807 · 2020-04-19T09:10:28Z

Any news on this?

Smit-create · 2020-04-19T16:38:09Z

I was wondering how to proceed further without scatter plots which are necessary for both FRV and DRV

czgdp1807 · 2020-04-20T07:34:23Z

Can we use histograms for both FRVs, and DRVs? I remember, plotting was also meant for random matrices too, though I am not sure how should they be represented on graphs.

sylee957 · 2020-04-20T10:24:43Z

The problem of histogram is that setting the bin size is arbitrary, and again I don't think that it is the best way to display discrete PMF than stem because the visuals are significantly affected by the width of the bins.

czgdp1807 · 2020-04-25T06:44:58Z

May be, https://matplotlib.org/3.2.1/api/_as_gen/matplotlib.pyplot.scatter.html can be tried out for FRV and DRV. Is there any support for wrapper of the above API in plotting module?

czgdp1807 · 2020-05-06T17:04:12Z

Any news on this?

Smit-create · 2020-05-06T18:22:49Z

Is there any support for wrapper of the above API in plotting module?

We currently don't have scatter plots available in plotting module. Also #19073 (comment)

czgdp1807 · 2020-05-06T18:27:22Z

What about using matplotlib API as suggested in #19073 (comment)
So, we should open a new issue for proposing inclusion of wrappers for scatter plots in plotting module. It's optional for you to work on that issue as it is out of scope of your GSoC project. Let's stall this PR until then if there isn't any better idea to plot FRVs and DRVs.

Smit-create added 3 commits April 5, 2020 16:38

add density_plot

3135cdb

xlim error remove

0b67ef5

Merge branch 'master' into stats_plot

522d3c6

Abdullahjavednesar requested a review from ritesh99rakesh April 5, 2020 17:49

Abdullahjavednesar requested review from jksuom and removed request for ritesh99rakesh April 5, 2020 17:50

Smit-create commented Apr 6, 2020

View reviewed changes

czgdp1807 added plotting stats labels Apr 6, 2020

Smit-create mentioned this pull request Apr 6, 2020

Accept label as argument in plotting #19079

Merged

czgdp1807 added the GSoC label May 5, 2020

czgdp1807 added the Stalled label May 6, 2020

Smit-create mentioned this pull request May 7, 2020

[Feature Request] Scatter plots support #19263

Open

czgdp1807 added Please take over and removed Stalled labels Jan 2, 2021

github-actions bot added the Merge conflict label Oct 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add density and cdf plot functions for random variables #19073

[WIP] Add density and cdf plot functions for random variables #19073

Smit-create commented Apr 5, 2020

sympy-bot commented Apr 5, 2020

sylee957 commented Apr 5, 2020

Smit-create commented Apr 5, 2020

sylee957 commented Apr 5, 2020

Smit-create commented Apr 6, 2020

Smit-create Apr 6, 2020

sylee957 Apr 6, 2020

czgdp1807 Apr 6, 2020

Smit-create Apr 6, 2020

czgdp1807 commented Apr 6, 2020 •

edited

czgdp1807 commented Apr 19, 2020

Smit-create commented Apr 19, 2020

czgdp1807 commented Apr 20, 2020

sylee957 commented Apr 20, 2020

czgdp1807 commented Apr 25, 2020

czgdp1807 commented May 6, 2020

Smit-create commented May 6, 2020

czgdp1807 commented May 6, 2020

[WIP] Add density and cdf plot functions for random variables #19073

Are you sure you want to change the base?

[WIP] Add density and cdf plot functions for random variables #19073

Conversation

Smit-create commented Apr 5, 2020

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

sympy-bot commented Apr 5, 2020

sylee957 commented Apr 5, 2020

Smit-create commented Apr 5, 2020

sylee957 commented Apr 5, 2020

Smit-create commented Apr 6, 2020

Smit-create Apr 6, 2020

Choose a reason for hiding this comment

sylee957 Apr 6, 2020

Choose a reason for hiding this comment

czgdp1807 Apr 6, 2020

Choose a reason for hiding this comment

Smit-create Apr 6, 2020

Choose a reason for hiding this comment

czgdp1807 commented Apr 6, 2020 • edited

czgdp1807 commented Apr 19, 2020

Smit-create commented Apr 19, 2020

czgdp1807 commented Apr 20, 2020

sylee957 commented Apr 20, 2020

czgdp1807 commented Apr 25, 2020

czgdp1807 commented May 6, 2020

Smit-create commented May 6, 2020

czgdp1807 commented May 6, 2020

czgdp1807 commented Apr 6, 2020 •

edited