-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept label as argument in plotting #19079
Conversation
✅ Hi, I am the SymPy bot (v158). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
@sylee957 Can you please look into the error at https://travis-ci.org/github/sympy/sympy/jobs/671587681?utm_medium=notification&utm_source=github_status? ...
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done
build succeeded.
The HTML pages are in _build/html.
cp -r src/pics _build/html/
Build finished. The HTML pages are in _build/html. I see a similar error here: https://travis-ci.org/github/sympy/sympy/jobs/671763962?utm_medium=notification&utm_source=github_status |
Codecov Report
@@ Coverage Diff @@
## master #19079 +/- ##
=============================================
+ Coverage 75.779% 75.781% +0.001%
=============================================
Files 650 650
Lines 168909 168909
Branches 39817 39817
=============================================
+ Hits 127999 128002 +3
+ Misses 35337 35334 -3
Partials 5573 5573 |
@sylee957 Does this look good to merge? |
References to other Issues or PRs
During the discussion in #19073, I found a useful feature to be added. Relevant comment #19073(comment)
Brief description of what is fixed or changed
The plot had
label
as an argument but it didn't accept the user passedlabel
and was set to default as a string of the expression which looks too bad when we have a long function.Other comments
Some of the examples where the current code in master fails are:
Example 1
Example 2
Example 3
After fixing them in this PR
Example 1
Example 2
Example 3
Release Notes
label
of the plots