Function for plotting shear force added #19237

Psycho-Pirate · 2020-05-01T15:10:35Z

References to other Issues or PRs

See #19202

Brief description of what is fixed or changed

A function for plotting shear force in 3D Beam is added.

Other comments

Release Notes

NO ENTRY

Psycho-Pirate · 2020-05-01T15:14:09Z

Here is an example:

>>> from sympy.physics.continuum_mechanics.beam import Beam3D
>>> from sympy import symbols
>>> l, E, G, I, A, x = symbols('l, E, G, I, A, x')
>>> b = Beam3D(30, E, G, I, A, x)
>>> b.apply_load(8, start=0, order=0, dir="y")
>>> b.apply_load(9*x, start=0, order=0, dir="z")
>>> b.bc_deflection = [(0, [0, 0, 0]), (30, [0, 0, 0])]
>>> R1, R2, R3, R4 = symbols('R1, R2, R3, R4')
>>> b.apply_load(R1, start=0, order=-1, dir="y")
>>> b.apply_load(R2, start=30, order=-1, dir="y")
>>> b.apply_load(R3, start=0, order=-1, dir="z")
>>> b.apply_load(R4, start=30, order=-1, dir="z")
>>> b.solve_for_reaction_loads(R1, R2, R3, R4)
>>> print(b.plot_shear_force())

Psycho-Pirate · 2020-05-01T15:15:02Z

Ping @moorepants @ishanaj @Sc0rpi0n101

codecov · 2020-05-01T19:15:43Z

Codecov Report

Merging #19237 (1543fcd) into master (226b942) will increase coverage by 0.124%.
The diff coverage is 9.677%.

@@              Coverage Diff              @@
##            master    #19237       +/-   ##
=============================================
+ Coverage   75.650%   75.774%   +0.124%     
=============================================
  Files          651       674       +23     
  Lines       169488    174249     +4761     
  Branches     40021     41128     +1107     
=============================================
+ Hits        128219    132037     +3818     
- Misses       35652     36498      +846     
- Partials      5617      5714       +97

sympy-bot · 2020-05-01T22:59:17Z

✅

Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

No release notes entry will be added for this pull request.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
See #19202

#### Brief description of what is fixed or changed
A function for plotting shear force in 3D Beam is added.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
NO ENTRY
<!-- END RELEASE NOTES -->

Psycho-Pirate · 2020-05-01T23:01:19Z

Please add the physics.continuum.mechanics and plotting labels

Psycho-Pirate · 2020-05-01T23:35:25Z

I have added a function for plotting shear force.
If this approach is approved, I will add other functions as well.
@moorepants @ishanaj @jashan498

czgdp1807 · 2020-09-05T17:00:14Z

@moorepants Is this good to go? Any thoughts on the changes by @Psycho-Pirate ?

ishanaj · 2020-09-05T18:42:49Z

sympy/physics/continuum_mechanics/beam.py

+            return Pz.show()
+        # For shear force along all direction
+        else:
+


This case should plot all the graphs as subplots in a single plot.

The values of shear force can vary greatly along different directions. See the example i mentioned above, shear force along y has smaller values in hundreds, while shear force along z has values in thousands. Having them on a same plot may not convey the information clearly. What do you suggest?

The values of shear force can vary greatly along different directions

I don't think that would be an issue. Just give it a try and share the plot results here. You can see how plot_loading_results() functions.

ishanaj · 2020-09-05T18:47:09Z

I think for all the different cases the same code is being repeated. It would be better if the code is separated and put inside a helper function which would return the plot whenever required

Psycho-Pirate · 2020-09-05T19:18:53Z

I think for all the different cases the same code is being repeated. It would be better if the code is separated and put inside a helper function which would return the plot whenever required

I agree! I will start working on this.

Psycho-Pirate · 2020-12-08T13:43:01Z

Please have a look @ishanaj

czgdp1807 · 2020-12-25T08:32:04Z

@ishanaj Please review this PR.

sympy/physics/continuum_mechanics/beam.py

ishanaj · 2020-12-25T17:15:03Z

It would be great if you could share some screenshots for the fourth case (dir='all' ) too.
The rest looks good.

sympy/physics/continuum_mechanics/beam.py

Psycho-Pirate · 2020-12-26T10:57:09Z

It would be great if you could share some screenshots for the fourth case (dir='all' ) too.
The rest looks good.

I have made the suggested changes and added an example in the docs as well.

>>> from sympy.physics.continuum_mechanics.beam import Beam3D
>>> from sympy import symbols
>>> l, E, G, I, A, x = symbols('l, E, G, I, A, x')
>>> b = Beam3D(20, E, G, I, A, x)
>>> b.apply_load(15, start=0, order=0, dir="z")
>>> b.apply_load(12*x, start=0, order=0, dir="y")
>>> b.bc_deflection = [(0, [0, 0, 0]), (20, [0, 0, 0])]
>>> R1, R2, R3, R4 = symbols('R1, R2, R3, R4')
>>> b.apply_load(R1, start=0, order=-1, dir="z")
>>> b.apply_load(R2, start=20, order=-1, dir="z")
>>> b.apply_load(R3, start=0, order=-1, dir="y")
>>> b.apply_load(R4, start=20, order=-1, dir="y")
>>> b.solve_for_reaction_loads(R1, R2, R3, R4)
>>> b.plot_shear_force('y')

>>> b.plot_shear_force()  #for all directions

Psycho-Pirate · 2020-12-26T11:02:40Z

Here's a screenshot of the docs with the example added.

ishanaj · 2020-12-26T17:29:10Z

Great work! Looks good to me.
@Psycho-Pirate are you intending to add other plotting functions too in this PR?

Psycho-Pirate · 2020-12-26T17:39:07Z

Great work! Looks good to me.
@Psycho-Pirate are you intending to add other plotting functions too in this PR?

Thanks!
I'm not planning about adding more plotting functions as of now because i have other issues pending and this pr has been open for months. But I'm open to suggestions about new plotting functions if you have any.

ishanaj · 2020-12-26T18:22:01Z

A plot function for bending moment, deflection, slope, should also be built in a similar manner. Maybe they can be added in a separate PR. Otherwise, I think this is good to go! @moorepants @czgdp1807

Psycho-Pirate · 2020-12-26T18:25:14Z

A plot function for bending moment, deflection, slope, should also be built in a similar manner.

I'll start working on them. Thanks for reviewing!

Psycho-Pirate · 2021-01-06T08:04:38Z

Please get this merged @czgdp1807 @moorepants

czgdp1807 · 2021-01-07T06:07:28Z

@asmeurer Could you please give merge access to @ishanaj ?
Many days have passed since merge approval was given and therefore I will wait till tomorrow to merge this. Thanks for the contributions.

oscarbenjamin · 2021-01-07T08:07:26Z

I have sent a request to add @ishanaj as a member. @ishanaj if you accept the request then you will be able to merge this.

ishanaj · 2021-01-07T09:28:57Z

Thanks @oscarbenjamin! I will be merging this now.

Function added

f032c6e

Abdullahjavednesar added the physics label May 1, 2020

sylee957 added physics.continuum_mechanics plotting and removed physics labels May 3, 2020

friyaz added the PR: sympy's turn label Jun 3, 2020

ishanaj reviewed Sep 5, 2020

View reviewed changes

helper function added

1543fcd

ishanaj reviewed Dec 25, 2020

View reviewed changes

sympy/physics/continuum_mechanics/beam.py Outdated Show resolved Hide resolved

ishanaj reviewed Dec 25, 2020

View reviewed changes

sympy/physics/continuum_mechanics/beam.py Show resolved Hide resolved

ishanaj reviewed Dec 25, 2020

View reviewed changes

sympy/physics/continuum_mechanics/beam.py Outdated Show resolved Hide resolved

Psycho-Pirate added 2 commits December 26, 2020 16:10

changes made

0bb5504

changes made

3aa0fb4

czgdp1807 closed this Jan 7, 2021

czgdp1807 reopened this Jan 7, 2021

ishanaj approved these changes Jan 7, 2021

View reviewed changes

ishanaj merged commit eb9543a into sympy:master Jan 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Function for plotting shear force added #19237

Function for plotting shear force added #19237

Psycho-Pirate commented May 1, 2020 •

edited

Psycho-Pirate commented May 1, 2020

Psycho-Pirate commented May 1, 2020

codecov bot commented May 1, 2020 •

edited

sympy-bot commented May 1, 2020 •

edited

Psycho-Pirate commented May 1, 2020

Psycho-Pirate commented May 1, 2020

czgdp1807 commented Sep 5, 2020

ishanaj Sep 5, 2020

Psycho-Pirate Sep 5, 2020

ishanaj Sep 5, 2020

ishanaj commented Sep 5, 2020

Psycho-Pirate commented Sep 5, 2020

Psycho-Pirate commented Dec 8, 2020

czgdp1807 commented Dec 25, 2020

ishanaj commented Dec 25, 2020

Psycho-Pirate commented Dec 26, 2020

Psycho-Pirate commented Dec 26, 2020

ishanaj commented Dec 26, 2020

Psycho-Pirate commented Dec 26, 2020

ishanaj commented Dec 26, 2020

Psycho-Pirate commented Dec 26, 2020

Psycho-Pirate commented Jan 6, 2021

czgdp1807 commented Jan 7, 2021

oscarbenjamin commented Jan 7, 2021

ishanaj commented Jan 7, 2021

Function for plotting shear force added #19237

Function for plotting shear force added #19237

Conversation

Psycho-Pirate commented May 1, 2020 • edited

References to other Issues or PRs

Brief description of what is fixed or changed

Other comments

Release Notes

Psycho-Pirate commented May 1, 2020

Psycho-Pirate commented May 1, 2020

codecov bot commented May 1, 2020 • edited

Codecov Report

sympy-bot commented May 1, 2020 • edited

Psycho-Pirate commented May 1, 2020

Psycho-Pirate commented May 1, 2020

czgdp1807 commented Sep 5, 2020

ishanaj Sep 5, 2020

Choose a reason for hiding this comment

Psycho-Pirate Sep 5, 2020

Choose a reason for hiding this comment

ishanaj Sep 5, 2020

Choose a reason for hiding this comment

ishanaj commented Sep 5, 2020

Psycho-Pirate commented Sep 5, 2020

Psycho-Pirate commented Dec 8, 2020

czgdp1807 commented Dec 25, 2020

ishanaj commented Dec 25, 2020

Psycho-Pirate commented Dec 26, 2020

Psycho-Pirate commented Dec 26, 2020

ishanaj commented Dec 26, 2020

Psycho-Pirate commented Dec 26, 2020

ishanaj commented Dec 26, 2020

Psycho-Pirate commented Dec 26, 2020

Psycho-Pirate commented Jan 6, 2021

czgdp1807 commented Jan 7, 2021

oscarbenjamin commented Jan 7, 2021

ishanaj commented Jan 7, 2021

Psycho-Pirate commented May 1, 2020 •

edited

codecov bot commented May 1, 2020 •

edited

sympy-bot commented May 1, 2020 •

edited