Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Added doit method in symbolic Probability #19696

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

Smit-create
Copy link
Member

Added doit method in symbolic Probability

References to other Issues or PRs

Brief description of what is fixed or changed

P=probability now calls Probability(...).doit()

Other comments

Release Notes

  • stats
    • Added doit in class Probability

ping @Upabjojr @czgdp1807 @jmig5776

@sympy-bot
Copy link

sympy-bot commented Jul 3, 2020

Hi, I am the SymPy bot (v160). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.7.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Added doit method in symbolic Probability
#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
`P=probability` now calls `Probability(...).doit()`

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* stats
    * Added `doit` in class `Probability`
<!-- END RELEASE NOTES -->
ping @Upabjojr @czgdp1807 @jmig5776 

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #19696 into master will increase coverage by 0.031%.
The diff coverage is 96.610%.

@@              Coverage Diff              @@
##            master    #19696       +/-   ##
=============================================
+ Coverage   75.670%   75.701%   +0.031%     
=============================================
  Files          658       659        +1     
  Lines       171250    171300       +50     
  Branches     40422     40406       -16     
=============================================
+ Hits        129585    129677       +92     
+ Misses       35992     35980       -12     
+ Partials      5673      5643       -30     

@Smit-create
Copy link
Member Author

@czgdp1807 @Upabjojr Please have a look if this looks to good to merge.

@Smit-create Smit-create requested a review from Upabjojr July 5, 2020 06:16
@czgdp1807
Copy link
Member

Tests passing, coverage is good. LGTM.

@Smit-create
Copy link
Member Author

@Upabjojr Does this look good to merge?

@Upabjojr
Copy link
Contributor

Upabjojr commented Jul 6, 2020

@Upabjojr Does this look good to merge?

Yes, it does!

@Upabjojr Upabjojr merged commit 1f7cbee into sympy:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants