New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .xreplace() to Vector and Dyadic #20446
Conversation
✅ Hi, I am the SymPy bot (v161). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.8. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #20446 +/- ##
=============================================
- Coverage 75.766% 75.757% -0.009%
=============================================
Files 673 673
Lines 174148 174402 +254
Branches 41112 41202 +90
=============================================
+ Hits 131945 132122 +177
- Misses 36491 36562 +71
- Partials 5712 5718 +6 |
@moorepants It's ready for review. |
@moorepants Shall I start working to add .simplify method, while this PR is in review? |
I believe they already have |
What's next to be added? I'm up for it! |
If you want to work on other things, I recommend finding open issues in the issue tracker. |
Yes, I'm doing that. Here #18064 (comment) you said more core methods are to be added, so I asked. |
I don't know others off the top of my head. You can always add everything that an expression has to make them 1-to-1 with expressions, but I'm not sure its worth it until someone presents a use case. |
@moorepants Please review, I have corrected the docstrings and have made them follow numpy conventions. |
Closing and opening to restart tests. |
@moorepants Please Review. |
Thanks @sidhu1012! LGTM. |
References to other Issues or PRs
Fixes #20445
Brief description of what is fixed or changed
Physics Vector and Dyadic is missing core sympy methods. This PR adds .xreplace() to these classes.
Other comments
Release Notes