Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for preactX. #7

Closed
wants to merge 1 commit into from
Closed

Support for preactX. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
/node_modules
/npm-debug.log
.DS_Store
test-reports
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"mkdirp": "^0.5.1",
"mocha": "^6.0.2",
"npm-run-all": "^4.1.5",
"preact": "^8.2.5",
"preact": "^10.0.0-beta.2",
"preact-jsx-chai": "^2.2.1",
"rimraf": "^2.6.3",
"rollup": "^1.7.0",
Expand Down
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default class Provider {
}

render(props) {
return props.children[0];
return props.children;
}
}

Expand Down Expand Up @@ -128,7 +128,7 @@ export class MergingProvider {
}

render(props) {
return props.children[0];
return props.children;
}
}

Expand Down
12 changes: 6 additions & 6 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe('preact-context-provider', () => {

it('should expose props into context', () => {
mount(<Provider {...context}><Spy /></Provider>);
expect(Spy).to.have.been.calledOnce.and.calledWith({ children: [] }, context);
expect(Spy).to.have.been.calledOnce.and.calledWith({}, context);
});

it('should overwrite higher context keys', () => {
Expand All @@ -32,7 +32,7 @@ describe('preact-context-provider', () => {
<Spy />
</Provider>
</Provider>);
expect(Spy).to.have.been.calledOnce.and.calledWith({ children: [] }, { a: 'overwrittenA', b: 'b' });
expect(Spy).to.have.been.calledOnce.and.calledWith({}, { a: 'overwrittenA', b: 'b' });

});

Expand All @@ -46,7 +46,7 @@ describe('preact-context-provider', () => {
<Spy />
</MergingProvider>
</MergingProvider>);
expect(Spy).to.have.been.calledOnce.and.calledWith({ children: [] },
expect(Spy).to.have.been.calledOnce.and.calledWith({},
{ a: { name: 'a', newProp: 'c' }, b: 'b' });
});

Expand All @@ -57,7 +57,7 @@ describe('preact-context-provider', () => {
<Spy />
</MergingProvider>
</MergingProvider>);
expect(Spy).to.have.been.calledOnce.and.calledWith({ children: [] },
expect(Spy).to.have.been.calledOnce.and.calledWith({},
{ a: { name: 'a', newProp: 'c' }, b: 'b' });
});

Expand All @@ -68,7 +68,7 @@ describe('preact-context-provider', () => {
<Spy />
</MergingProvider>
</MergingProvider>);
expect(Spy).to.have.been.calledOnce.and.calledWith({ children: [] },
expect(Spy).to.have.been.calledOnce.and.calledWith({},
{ a: { name: 'a', newProp: 'c' }, b: { newProp: 'd' } });
});

Expand All @@ -79,7 +79,7 @@ describe('preact-context-provider', () => {
<Spy />
</MergingProvider>
</MergingProvider>);
expect(Spy).to.have.been.calledOnce.and.calledWith({ children: [] },
expect(Spy).to.have.been.calledOnce.and.calledWith({},
{ a: null, b: { name: 'b', newProp: 'd' } });
});
});
Expand Down