Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error template assumes production is false #432

Closed
spruce-bruce opened this issue Apr 16, 2019 · 0 comments
Closed

Error template assumes production is false #432

spruce-bruce opened this issue Apr 16, 2019 · 0 comments
Labels
bug Something isn't working major Severity: Affects major functionality or major data. It has a workaround but is not obvious.
Projects

Comments

@spruce-bruce
Copy link
Collaborator

Any errors being rendered by hapi instead of the node-oidc-provider plugin will always set the production template variable to false. This includes things like invite tokens expiring, but does not include things like OIDC session expiration errors (or invalid OIDC link errors, etc).

const template = await lib.themeService.renderThemedTemplate('error', {

@spruce-bruce spruce-bruce added the bug Something isn't working label Apr 16, 2019
@synbot synbot added this to Dev: Ready in v2.9.1 Apr 16, 2019
@bobeagan bobeagan added the major Severity: Affects major functionality or major data. It has a workaround but is not obvious. label May 3, 2019
@chrisshiplet chrisshiplet moved this from Dev: Ready to Dev: In Process in v2.9.1 Dec 16, 2019
@chrisshiplet chrisshiplet moved this from Dev: In Process to QA: Ready in v2.9.1 Dec 17, 2019
@chrisshiplet chrisshiplet moved this from QA: Ready to Done in v2.9.1 Jan 6, 2020
@synbot synbot closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Severity: Affects major functionality or major data. It has a workaround but is not obvious.
Projects
No open projects
Development

No branches or pull requests

4 participants