Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update makes headers nearly unreadable when using dark mode #1915

Closed
LinuxOnTheDesktop opened this issue Jun 13, 2023 · 2 comments · Fixed by #1916
Closed

Latest update makes headers nearly unreadable when using dark mode #1915

LinuxOnTheDesktop opened this issue Jun 13, 2023 · 2 comments · Fixed by #1916

Comments

@LinuxOnTheDesktop
Copy link

LinuxOnTheDesktop commented Jun 13, 2023

Please see the top of this screenshot:
Screenshot_20230613-012529297

Previously, the header text was not white-on-light. (EDITED.)

Version Information

App Version: 1.23.5
Syncthing Version: 1.23.5
Android Version: Android 13
@imsodin
Copy link
Member

imsodin commented Jun 13, 2023

This is most likely an effect of #1895 - @Bnyro, could you take a look at this please.

@Bnyro
Copy link
Contributor

Bnyro commented Jun 13, 2023

It should be fixable by modifying or removing the two following lines:

android:background="?colorPrimary"

android:background="?colorPrimary"

We can either use colorSecondary or remove the lines, so that a variant of the background color is used automatically (second might be the best).

Then we also need to modify the status bar color:

<item name="android:statusBarColor" tools:targetApi="m">?attr/colorPrimary</item>

It should either fit the other color we picked for the toolbar (e.g. colorSecondary) or we could use @android:color/transparent for the second option.

I'll open a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants