Notifications not working in 1.25.0-rc.1.1

[schlamar]

After updating to 1.25.0-rc.1.1, I'm no longer getting a notification from Syncthing. Looks like notifications are completely disabled for the application, as there is no configuration setting for notifications in Android App-Info for Syncthing (Settings -> Apps -> Syncthing). Other apps has a notification setting above Permissions in App-Info. This section is completely missing for Syncthing.

Could be a regression from #1972

Version Information

App Version: 1.25.0-rc.1.1
Syncthing Version: v1.25.0-rc.1
Android Version: 13

[imsodin]

Thanks for reporting this, especially during beta!

Seems like some new permission we need to specify/ask for: https://developer.android.com/develop/ui/views/notifications/notification-permission

Lovely how they mention notification behaviour changes in the target sdk 33 change guide, but fail to mention that this permission is new...
Edit: There's another guide about android 13 (not target sdk), and that one does mention the new permission. Looks like I should also closely follow every android releases behaviour changes (spoiler alert: I likely wont). Would be so nice if someone anyway doing android dev would join me as a co-maintainer - so little work, such a big impact (we have 6 digit users).

[githubashutoshsoni]

Sure, I'm willing to take this up. @schlamar can you assign this to me?

[schlamar]

No, I'm just reporter.
@imsodin should do this.

[imsodin]

No need just sending a pr is fine and would be much appreciated.

[githubashutoshsoni]

Great, @imsodin. I think I've added this and tested in android 13. Can you please verify?

[githubashutoshsoni]

#1983 mostly fixes this issue with notification.

[schlamar]

Can confirm that this was fixed in 1.26.0-rc.2