Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

Don't share folders with all known devices #17

Closed
lapo-luchini opened this issue Jan 31, 2018 · 5 comments · Fixed by #113
Closed

Don't share folders with all known devices #17

lapo-luchini opened this issue Jan 31, 2018 · 5 comments · Fixed by #113

Comments

@lapo-luchini
Copy link

I added two devices, let's say A and B, the first offers the directory Apples the second offers the directory Bananas; on A I got a pop-up asking if I want to accept directory Apples from (mobile device running Lite version).
I didn't check the internals of the protocol, is this expected?

@Nutomic
Copy link

Nutomic commented Jan 31, 2018

See this issue that you opened yourself a year ago ;)

davide-imbriaco#4

@lapo-luchini
Copy link
Author

Ehm, sorry, memory can be fickle. 😅

@steveej
Copy link

steveej commented Feb 18, 2018

Adding some details that I'm encountering:

  • the folder that is shared back by the syncthing-lite client has a folder-id that equals the folder-name.
  • clicking "later" on the share request will immediately bring the request back. Are we supposed to actually add this share?

@Nutomic
Copy link

Nutomic commented Feb 19, 2018

No, you can ignore that folder. Its just that the library doesnt yet support selective sharing of folders, so every folder is shared with every device.

@Nutomic Nutomic changed the title Lite version offering sync of other device shares Don't share folders with all known devices Nov 6, 2018
@l-jonas
Copy link

l-jonas commented Nov 8, 2018

There are two options for this:

  1. Only tell a device about a folder when the device told this App about it (save it locally) - problem: Knowing a folder id is enough to trick this App to eventually do file uploads to this device
  2. Add a UI to select devices for folders, accept the first device which shares a folder automatically

@syncthing syncthing locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants