Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xattrs not properly applied to directories, causes rescan/resync loop #8657

Closed
calmh opened this issue Nov 8, 2022 · 0 comments
Closed

Xattrs not properly applied to directories, causes rescan/resync loop #8657

calmh opened this issue Nov 8, 2022 · 0 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.22.2

Comments

@calmh
Copy link
Member

calmh commented Nov 8, 2022

Syncthing thinks it should apply xattrs to directories, but it doesn't. That results in the next scan picking up the absence of xattrs as a change which gets sent out. The other side "applies" that change (it doesn't, since it doesn't set xattrs), then the next scan it rediscovers the xattrs. Etc.
@calmh calmh added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated and removed needs-triage New issues needed to be validated labels Nov 8, 2022
@luckman212 luckman212 mentioned this issue Nov 8, 2022
Closed
@calmh calmh closed this as completed in a523fef Nov 9, 2022
@bt90 bt90 mentioned this issue Nov 9, 2022
Merged
@calmh calmh added this to the v1.22.2 milestone Nov 9, 2022
@luckman212 luckman212 mentioned this issue Nov 10, 2022
Closed
calmh added a commit to calmh/syncthing that referenced this issue Nov 22, 2022
@calmh
Merge branch 'main' into linuxbuild
4ee1015 
* main: (23 commits)
  lib/fs: Optimize WindowsInvalidFilename (syncthing#8687)
  gui, man, authors: Update docs, translations, and contributors
  cmd/syncthing: Use main logger in generate subcommand (fixes syncthing#8682) (syncthing#8685)
  build: Update all dependencies (fixes syncthing#8679) (syncthing#8680)
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Correctly set xattrs on temp files (fixes syncthing#8667) (syncthing#8670)
  gui: Automatically dismiss authentication reminder when in LDAP mode (fixes syncthing#8661) (syncthing#8663)
  lib/model: Correctly handle xattrs on directories (fixes syncthing#8657) (syncthing#8658)
  lib/protocol: Ignore inode time when xattr&ownership is ignored (fixes syncthing#8654) (syncthing#8655)
  lib/fs: Try to remove read only Windows files (fixes syncthing#3744) (syncthing#8650)
  gui: Add copy to clipboard, share by email, and share by SMS buttons to device IDs (fixes syncthing#2771, ref syncthing#3868) (syncthing#7984)
  gui, man, authors: Update docs, translations, and contributors
  build: Add GitHub actions build for Windows (syncthing#8627)
  gui: Fix connection type icon width (fixes syncthing#8592) (syncthing#8644)
  gui: Adjust connection type icon size scaling and alignment (syncthing#8645)
  docker: Use healthcheck endpoint (syncthing#8640)
  lib/connections: Use adaptive write size for rate limited connections (fixes syncthing#8630) (syncthing#8631)
  gui: Mark devices that haven't connected for a long time (fixes syncthing#7703) (syncthing#8530)
  gui: Fix rescan interval when add encrypted folder with watch for changes enabled (fixes syncthing#8570) (syncthing#8571)
  gui: Always show Out of Sync Items for remote devices (syncthing#8632)
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 9, 2023
@syncthing syncthing locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.22.2
Development

No branches or pull requests
2 participants
@calmh @st-review