Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgui complains about not set password in ldap mode #8661

Closed
cyberb opened this issue Nov 9, 2022 · 6 comments
Closed

webgui complains about not set password in ldap mode #8661

cyberb opened this issue Nov 9, 2022 · 6 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion needs-triage New issues needed to be validated
Milestone

Comments

@cyberb
Copy link
Contributor

cyberb commented Nov 9, 2022

Webgui says Username/Password has not been set for the GUI authentication in ldap mode.

Should not do this in ldap mode.

@cyberb cyberb added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Nov 9, 2022
@calmh
Copy link
Member

calmh commented Nov 9, 2022

This is a notification that is set on first startup. Presumably you setup LDAP after first startup -- then just acknowledge the notification and it's gone; you've done what it asks you to, by configuring LDAP. If you somehow set up authentication before first startup (because you generated an XML config) I don't think it should display at all.

@cyberb
Copy link
Contributor Author

cyberb commented Nov 9, 2022

I am generating the config with ldap mode before the first start, but I still see this notification (which I ack and it goes away), maybe I am missing some config to not show it at all?

@cyberb
Copy link
Contributor Author

cyberb commented Nov 9, 2022

If I understand this correctly auto dismissal happens only if login and password are set:

if (guiCfg.user && guiCfg.password) {

@cyberb
Copy link
Contributor Author

cyberb commented Nov 9, 2022

Not to confuse with openNoAuth warning which is different and is handling ldap mode correctly

@cyberb
Copy link
Contributor Author

cyberb commented Nov 10, 2022

Did not test this but it probably should look like this: #8663

@calmh
Copy link
Member

calmh commented Nov 10, 2022

If you're generating a config yourself I don't see how this could happen. Syncthing has a concept of notifications that need to be acknowledged, and adds this to the config when generating a new configuration without authentication:

<unackedNotificationID>authenticationUserAndPassword</unackedNotificationID>

If you generate a config and don't add that notification, I don't think Syncthing will either.

@calmh calmh closed this as completed in 1b32e9f Nov 10, 2022
@calmh calmh added this to the v1.22.2 milestone Nov 11, 2022
calmh added a commit to calmh/syncthing that referenced this issue Nov 22, 2022
* main: (23 commits)
  lib/fs: Optimize WindowsInvalidFilename (syncthing#8687)
  gui, man, authors: Update docs, translations, and contributors
  cmd/syncthing: Use main logger in generate subcommand (fixes syncthing#8682) (syncthing#8685)
  build: Update all dependencies (fixes syncthing#8679) (syncthing#8680)
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Correctly set xattrs on temp files (fixes syncthing#8667) (syncthing#8670)
  gui: Automatically dismiss authentication reminder when in LDAP mode (fixes syncthing#8661) (syncthing#8663)
  lib/model: Correctly handle xattrs on directories (fixes syncthing#8657) (syncthing#8658)
  lib/protocol: Ignore inode time when xattr&ownership is ignored (fixes syncthing#8654) (syncthing#8655)
  lib/fs: Try to remove read only Windows files (fixes syncthing#3744) (syncthing#8650)
  gui: Add copy to clipboard, share by email, and share by SMS buttons to device IDs (fixes syncthing#2771, ref syncthing#3868) (syncthing#7984)
  gui, man, authors: Update docs, translations, and contributors
  build: Add GitHub actions build for Windows (syncthing#8627)
  gui: Fix connection type icon width (fixes syncthing#8592) (syncthing#8644)
  gui: Adjust connection type icon size scaling and alignment (syncthing#8645)
  docker: Use healthcheck endpoint (syncthing#8640)
  lib/connections: Use adaptive write size for rate limited connections (fixes syncthing#8630) (syncthing#8631)
  gui: Mark devices that haven't connected for a long time (fixes syncthing#7703) (syncthing#8530)
  gui: Fix rescan interval when add encrypted folder with watch for changes enabled (fixes syncthing#8570) (syncthing#8571)
  gui: Always show Out of Sync Items for remote devices (syncthing#8632)
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Nov 10, 2023
@syncthing syncthing locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion needs-triage New issues needed to be validated
Projects
None yet
Development

No branches or pull requests

3 participants