gui: Always show Out of Sync Items for remote devices

[tomasz1986]

Right now, the Out of Sync Items list for a specific remote device is
available only when the device is online and currently synchronising.
However, the list itself is being created by Syncthing all the time, so
there is no need to hide it from the user even when the remote device is
offline or paused. This way they can always easily check which files
exactly have not been synchronised yet.

In addition, the Out of Sync Items entry already includes file size next
to it, so there is no need to display it again next to the Sync Status
entry. Thus, remove out-of-sync file size from Sync Status, leaving only
percentage next to it.

Signed-off-by: Tomasz Wilczyński twilczynski@naver.com

Screenshots

Before (Out of Sync Items present only when online and syncing)

After (Out of sync Items present always, as long as there is any)

[nekr0z]

If I remember correctly, the rationale behind the current behavior was that when a remote device is not connected, there is no way to know its state (it may have connected to a third device that has all the data and sync everything from there, we don't know), hence it would be misleading to display it. What changed?

[tomasz1986]

That's a good point. The same can be applied to the currently displayed "Sync Status" though, can't it?

[nekr0z]

The same can be applied to the currently displayed "Sync Status" though, can't it?

Not really, no. With the local status we can know for sure that we've at least seen some global state that we haven't yet caught up to. We can't be sure there are no global changes that we know not of yet, but we can at least positively know that we lack something.

As for a remote device, we can not know its state unless we are connected to it this exact moment.

[tomasz1986]

I'm not talking about the global state 😉. I'm talking about "Sync Status" (which is also visible in the screenshot above). It was added somewhat recently in #8401. I think of this PR as an extension to that one, really (as in why show the percentage and file size but not the files themselves?).

[nekr0z]

I'm talking about "Sync Status"

Oh, I must have missed that one. Indeed, the inclusion of that one invalidates my objections; please accept my apologies for not keeping up.

I think of this PR as an extension to that one, really

In this capacity, looks OK.

[acolomb]

Oh, I must have missed that one. Indeed, the inclusion of that one invalidates my objections; please accept my apologies for not keeping up.

But does it really invalidate the objections? I think they're spot on, we cannot know how much a remote device is out of sync when we are not connected to them, but they might already have gotten our latest changes from some third party. So in fact, showing this state is possibly misleading until we do establish a connection again.

At least there should be a clear indication / explanation that this info is just a guess from when we last had a direct connection to the respective remote. That's actually a shortcoming of #8401 already, not necessarily a regression introduced here. But this additional level of detail makes it seem more trustworthy when in fact it isn't.

[tomasz1986]

At least there should be a clear indication / explanation that this info is just a guess from when we last had a direct connection to the respective remote. That's actually a shortcoming of #8401 already, not necessarily a regression introduced here. But this additional level of detail makes it seem more trustworthy when in fact it isn't.

There is more to that, e.g. the whole Sync Status doesn't take into account files ignored by the remote device, so if you make local changes to files that are ignored there, the status will be "incomplete", even though in reality the two are in sync. This applies to both Sync Status with its percentage, and the list of files with their size. Despite that, I still find this very useful when dealing with devices that I've got 100% control and know which files are present where. Obviously, if we're a part of a larger network, where devices belong to different entities, then there's no way to know the real remote state before actually connecting with the device.

Would a tooltip note suffice here? I'm thinking about something similar to what's currently used for the recently added connection type information, where each of them on hover displays a short explanation of what it is.

[acolomb]

Yeah I guess a tool tip is fine. And something more elaborate in the documentation. In the out of sync items dialog, a longer note could be displayed when the corresponding remote is disconnected.

Regarding ignored files, that's actually correct to display out of sync. They don't have the files, so not in sync. Period. Locally ignoring stuff is explicitly asking to stay out of sync, so other devices should not get lied to about it.