lib/logger: Disable debug flags without debugging (fixes #4780) #5278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudriusButkevicius
previously approved these changes
Oct 18, 2018
lib/logger/logger.go
Outdated
| l.debug[facility] = enabled | ||
| l.mut.Unlock() | ||
| l.SetFlags(DebugFlags) | ||
| if enabled { |
There was a problem hiding this comment.
l.debug could be map[string]struct{} where entry being there implies its on, entry not being there implies its off. Then enabled or not is just a len() over the map.
Also, I'd want to add shortfile to default log flags, @calmh?
There was a problem hiding this comment.
Why? I think that’s mostly noise to most people, no?
AudriusButkevicius
approved these changes
Oct 18, 2018
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#4780
Testing
manual