cmd/syncthing/cli: Add show discovery command (fixes #8007) #8378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsodin
changed the title
imsodin
reviewed
Jun 7, 2022
cmd/syncthing/cli/show.go
Outdated
| @@ -35,6 +35,11 @@ var showCommand = cli.Command{ | |||
| Usage: "Report about connections to other devices", | |||
| Action: expects(0, indexDumpOutput("system/connections")), | |||
| }, | |||
| { | |||
| Name: "discovery", | |||
| Usage: "Report about the local discovery cache", | |||
There was a problem hiding this comment.
Thanks for your contribution!
I know the docs contain the same sentence, however with (supposedly) more user interactions with this command it would be nice if it was a bit more descriptive. E.g. "Discovered addresses of remote devices (from cache of the running syncthing instance)". The cache bit is relevant, such that no-one thinks it looks it up actively e.g. from global discovery servers due to this method - "of the running syncthing instance" may be overly verbouse and not add anything, not sure - anyway all just a suggestions.
imsodin
reviewed
Jun 7, 2022
| { | ||
| Name: "discovery", | ||
| Usage: "Report about the local discovery cache", | ||
| Action: expects(0, indexDumpOutput("system/discovery")), |
There was a problem hiding this comment.
That's definitely a misnomer by now - prettyPrintOutput or something would be more appropriate. Not something needed to be addressed here.
|
@imsodin Thanks for your response. I changed the description to your proposal. |
acolomb
approved these changes
Jun 11, 2022
|
Would love to see this happen. Just now I had been looking for exactly that command again without success. @imsodin I think your review comments were addressed? |
imsodin
changed the title
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jul 21, 2022
* main: gui, man, authors: Update docs, translations, and contributors cmd/syncthing/cli: Add show discovery command (fixes syncthing#8007) (syncthing#8378) gui, man, authors: Update docs, translations, and contributors lib/osutil: Only announce address of interfaces which are up (fixes syncthing#7458) (syncthing#8422) gui: Fix missing span end tag and missing nbsp semicolon in HTML (syncthing#8419)
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jul 28, 2022
* main: cmd/syncthing, lib/config: Remove restartOnWakeup option & functionality (fixes syncthing#8448) (syncthing#8449) gui: Remove blank meta tags (syncthing#8362) gui: Add device sync status (fixes syncthing#7981) (syncthing#8401) gui: Fix detailed staggered versioning information in folder info (ref syncthing#8348) (syncthing#8433) all: Support syncing ownership (fixes syncthing#1329) (syncthing#8434) gui, man, authors: Update docs, translations, and contributors lib/model, lib/config: Apply sensible defaults for auto-accepted encrypted folder (fixes syncthing#8296) (syncthing#8427) gui: Move filesystem watcher explanation from tooltip to help block (syncthing#8432) gui: Use discovered IDs from cache when adding a new remote device (syncthing#8382) build: Update goleveldb (syncthing#8440) gui, man, authors: Update docs, translations, and contributors cmd/syncthing/cli: Add show discovery command (fixes syncthing#8007) (syncthing#8378) gui, man, authors: Update docs, translations, and contributors lib/osutil: Only announce address of interfaces which are up (fixes syncthing#7458) (syncthing#8422) gui: Fix missing span end tag and missing nbsp semicolon in HTML (syncthing#8419)
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add show disovery command to cli (fixes #8007)
Testing
Execute
syncthing cli show discoveryon the command lineDocumentation
Since the other show commands are not described in the documentation as far as I have seen, I don't think a change is necessary.
Authorship
Your name and email will be added automatically to the AUTHORS file
based on the commit metadata.