Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: remove blank meta tags #8362

Merged
merged 3 commits into from Jul 26, 2022
Merged

gui: remove blank meta tags #8362

merged 3 commits into from Jul 26, 2022

Conversation

lsmithx2
Copy link
Contributor

remove blank meta tags

Purpose

Remove blank meta tags in header.

Testing

None needed

Screenshots

N/A

Documentation

Remove blank meta tags from header.

Authorship

Your name and email will be added automatically to the AUTHORS file
based on the commit metadata.

@tomasz1986
Copy link
Contributor

The empty tags are indeed not required in HTML5, but what's up with the jQuery update? As a matter of fact, adding the file like that doesn't actually do anything, because jquery-2.2.2.js is hard-coded in the HTML.

@lsmithx2
Copy link
Contributor Author

The empty tags are indeed not required in HTML5, but what's up with the jQuery update? As a matter of fact, adding the file like that doesn't actually do anything, because jquery-2.2.2.js is hard-coded in the HTML.

I was testing that in my branch I did not mean to commit that.

@tomasz1986
Copy link
Contributor

tomasz1986 commented May 25, 2022 •
edited

I was testing that in my branch I did not mean to commit that.

Please remove the file then, if it's not a problem for you 🙂. I'd also like to ask to change the PR title from remove blank meta tags to gui: remove blank meta tags to match the overall convention.

Other than that, everything looks fine to me, unless there's a plan to fill the two tags with some actual useful information.

@lsmithx2 lsmithx2 changed the title remove blank meta tags gui: remove blank meta tags May 25, 2022
@lsmithx2
Copy link
Contributor Author

I was testing that in my branch I did not mean to commit that.

Please remove the file then, if it's not a problem for you 🙂. I'd also like to ask to change the PR title from remove blank meta tags to gui: remove blank meta tags to match the overall convention.

Other than that, everything looks fine to me, unless there's a plan to fill the two tags with some actual useful information.

No problem I have completed these changes.

@calmh calmh merged commit 1b575b4 into syncthing:main Jul 26, 2022
calmh added a commit to calmh/syncthing that referenced this pull request Jul 28, 2022
@calmh
Merge branch 'main' into xattr
da3fe7a 
* main:
  cmd/syncthing, lib/config: Remove restartOnWakeup option & functionality (fixes syncthing#8448) (syncthing#8449)
  gui: Remove blank meta tags (syncthing#8362)
  gui: Add device sync status (fixes syncthing#7981) (syncthing#8401)
  gui: Fix detailed staggered versioning information in folder info (ref syncthing#8348) (syncthing#8433)
  all: Support syncing ownership (fixes syncthing#1329) (syncthing#8434)
  gui, man, authors: Update docs, translations, and contributors
  lib/model, lib/config: Apply sensible defaults for auto-accepted encrypted folder (fixes syncthing#8296) (syncthing#8427)
  gui: Move filesystem watcher explanation from tooltip to help block (syncthing#8432)
  gui: Use discovered IDs from cache when adding a new remote device (syncthing#8382)
  build: Update goleveldb (syncthing#8440)
  gui, man, authors: Update docs, translations, and contributors
  cmd/syncthing/cli: Add show discovery command (fixes syncthing#8007) (syncthing#8378)
  gui, man, authors: Update docs, translations, and contributors
  lib/osutil: Only announce address of interfaces which are up (fixes syncthing#7458) (syncthing#8422)
  gui: Fix missing span end tag and missing nbsp semicolon in HTML (syncthing#8419)
calmh added a commit to calmh/syncthing that referenced this pull request Jul 28, 2022
@calmh
Merge branch 'main' into runtimeos
6315579 
* main:
  all: Fix unused method receiver (further) (syncthing#8466)
  all: Minor deprecation updates
  lib/model: Clarify normal shallow copy
  lib/api: Missing error handling in config handler (syncthing#8463)
  all: Remove unused method receivers (syncthing#8462)
  all: Combine sequential appends (syncthing#8461)
  cmd/ursrv: Silence linter with correct regexps (syncthing#8460)
  all: Unused parameter should be replaced by underscore (syncthing#8464)
  all: Remove or convert deprecated API usages (syncthing#8459)
  lib/config: Remove unnecessary use of `fmt.Sprintf` (syncthing#8458)
  lib/model: Replace `for` loop with `append` (syncthing#8457)
  all: Fix check for empty string (syncthing#8456)
  cmd/syncthing, lib/config: Remove restartOnWakeup option & functionality (fixes syncthing#8448) (syncthing#8449)
  gui: Remove blank meta tags (syncthing#8362)
  gui: Add device sync status (fixes syncthing#7981) (syncthing#8401)
  gui: Fix detailed staggered versioning information in folder info (ref syncthing#8348) (syncthing#8433)
@calmh calmh added this to the v1.21.0 milestone Aug 9, 2022
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jul 26, 2023
@syncthing syncthing locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@calmh calmh calmh approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lsmithx2 @tomasz1986 @calmh @st-review