gui: Fix detailed staggered versioning information in folder info (ref #8348) #8433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…syncthing#8348) Currently, there are two issues with the detailed staggered versioning information displayed in the folder info. Firstly, the maxAge value of 365d is displayed despite matching the default. Secondly, there is no consideration for the special case of maxAge equal to 0, meaning that versions are kept forever. This commit fixes both of those issues, so that the default maxAge is not displayed and its value of 0 is displayed as "forever". Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
|
alternatively you could use trash can symbol and "no" as text |
|
I personally don't like using a trash can icon here, as there is "Trash Can" versioning already, and using such an icon with other types of versioning could be confusing. That's also why I chose the calendar icon instead in the first place. The wording "forever" comes from the description in the versioning settings.
|
calmh
approved these changes
Jul 26, 2022
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jul 28, 2022
* main: cmd/syncthing, lib/config: Remove restartOnWakeup option & functionality (fixes syncthing#8448) (syncthing#8449) gui: Remove blank meta tags (syncthing#8362) gui: Add device sync status (fixes syncthing#7981) (syncthing#8401) gui: Fix detailed staggered versioning information in folder info (ref syncthing#8348) (syncthing#8433) all: Support syncing ownership (fixes syncthing#1329) (syncthing#8434) gui, man, authors: Update docs, translations, and contributors lib/model, lib/config: Apply sensible defaults for auto-accepted encrypted folder (fixes syncthing#8296) (syncthing#8427) gui: Move filesystem watcher explanation from tooltip to help block (syncthing#8432) gui: Use discovered IDs from cache when adding a new remote device (syncthing#8382) build: Update goleveldb (syncthing#8440) gui, man, authors: Update docs, translations, and contributors cmd/syncthing/cli: Add show discovery command (fixes syncthing#8007) (syncthing#8378) gui, man, authors: Update docs, translations, and contributors lib/osutil: Only announce address of interfaces which are up (fixes syncthing#7458) (syncthing#8422) gui: Fix missing span end tag and missing nbsp semicolon in HTML (syncthing#8419)
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jul 28, 2022
* main: all: Fix unused method receiver (further) (syncthing#8466) all: Minor deprecation updates lib/model: Clarify normal shallow copy lib/api: Missing error handling in config handler (syncthing#8463) all: Remove unused method receivers (syncthing#8462) all: Combine sequential appends (syncthing#8461) cmd/ursrv: Silence linter with correct regexps (syncthing#8460) all: Unused parameter should be replaced by underscore (syncthing#8464) all: Remove or convert deprecated API usages (syncthing#8459) lib/config: Remove unnecessary use of `fmt.Sprintf` (syncthing#8458) lib/model: Replace `for` loop with `append` (syncthing#8457) all: Fix check for empty string (syncthing#8456) cmd/syncthing, lib/config: Remove restartOnWakeup option & functionality (fixes syncthing#8448) (syncthing#8449) gui: Remove blank meta tags (syncthing#8362) gui: Add device sync status (fixes syncthing#7981) (syncthing#8401) gui: Fix detailed staggered versioning information in folder info (ref syncthing#8348) (syncthing#8433)
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are two issues with the detailed staggered versioning
information displayed in the folder info. Firstly, the maxAge value of
365d is displayed despite matching the default. Secondly, there is no
consideration for the special case of maxAge equal to 0, meaning that
versions are kept forever.
This commit fixes both of those issues, so that the default maxAge is
not displayed and its value of 0 is displayed as "forever".
Signed-off-by: Tomasz Wilczyński twilczynski@naver.com
Screenshots
Before
maxAge set to 365d
maxAge set to 0
After
maxAge set to 365d
maxAge set to 0