all: Remove or convert deprecated API usages #8459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jul 28, 2022
* main: all: Fix unused method receiver (further) (syncthing#8466) all: Minor deprecation updates lib/model: Clarify normal shallow copy lib/api: Missing error handling in config handler (syncthing#8463) all: Remove unused method receivers (syncthing#8462) all: Combine sequential appends (syncthing#8461) cmd/ursrv: Silence linter with correct regexps (syncthing#8460) all: Unused parameter should be replaced by underscore (syncthing#8464) all: Remove or convert deprecated API usages (syncthing#8459) lib/config: Remove unnecessary use of `fmt.Sprintf` (syncthing#8458) lib/model: Replace `for` loop with `append` (syncthing#8457) all: Fix check for empty string (syncthing#8456) cmd/syncthing, lib/config: Remove restartOnWakeup option & functionality (fixes syncthing#8448) (syncthing#8449) gui: Remove blank meta tags (syncthing#8362) gui: Add device sync status (fixes syncthing#7981) (syncthing#8401) gui: Fix detailed staggered versioning information in folder info (ref syncthing#8348) (syncthing#8433)
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jul 28, 2022
* main: (22 commits) lib/model: Use bytes.Equal instead of converting to string (syncthing#8469) all: Add build constants for runtime.GOOS comparisons (syncthing#8442) cmd/strelaysrv: Fix superfluous else statements (syncthing#8468) all: Fix nested `if` with `else if` (syncthing#8467) all: Unused errors lib/fs: Consolidate append in test lib/api: Further (final?) unused parameters removal cmd/syncthing: Incorrect error handling lib/api: String comparisons lib/api: Remove unused parameters all: Fix unused method receiver (further) (syncthing#8466) all: Minor deprecation updates lib/model: Clarify normal shallow copy lib/api: Missing error handling in config handler (syncthing#8463) all: Remove unused method receivers (syncthing#8462) all: Combine sequential appends (syncthing#8461) cmd/ursrv: Silence linter with correct regexps (syncthing#8460) all: Unused parameter should be replaced by underscore (syncthing#8464) all: Remove or convert deprecated API usages (syncthing#8459) lib/config: Remove unnecessary use of `fmt.Sprintf` (syncthing#8458) ...
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per DeepSource