Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual_PET_Answer notebooks don't have update_bowsher_weights #199

Closed
KrisThielemans opened this issue Jan 26, 2023 · 1 comment
Closed

Dual_PET_Answer notebooks don't have update_bowsher_weights #199

KrisThielemans opened this issue Jan 26, 2023 · 1 comment
Labels
wontfix This will not be worked on

Comments

@KrisThielemans
Copy link
Member

The user still has to copy it from the MAPEM_Bowsher notebook
@KrisThielemans KrisThielemans added this to the v3.5 milestone Jan 26, 2023
@KrisThielemans KrisThielemans changed the title Dual_PET_Answer notebooks doesn't have update_bowsher_weights Dual_PET_Answer notebooks don't have update_bowsher_weights Jan 26, 2023
@KrisThielemans KrisThielemans added the wontfix This will not be worked on label Jun 22, 2023
@KrisThielemans KrisThielemans removed this from the v3.5 milestone Jun 22, 2023
@KrisThielemans
Copy link
Member Author

I now think this is fine. The notebooks say what to do (i.e. "copy functions from..."). It does mean that the answer notebooks cannot be run from start to finish, but duplicating those lines isn't great either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KrisThielemans