Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dis/enable ROOT support in STIR by default #21

Closed
KrisThielemans opened this issue May 5, 2017 · 2 comments · Fixed by #630
Closed

dis/enable ROOT support in STIR by default #21

KrisThielemans opened this issue May 5, 2017 · 2 comments · Fixed by #630
Milestone
v3.4

Comments

@KrisThielemans
Copy link
Member

provide option to enable for advanced users
@KrisThielemans KrisThielemans added this to the v1.0 milestone May 5, 2017
@KrisThielemans
Copy link
Member Author

It is disabled now. we'll provide the option to enable later.

@KrisThielemans KrisThielemans modified the milestones: v1.0.0, v1.1 Dec 19, 2017
@KrisThielemans KrisThielemans changed the title disable ROOT support in STIR by default dis/enable ROOT support in STIR by default Dec 20, 2017
@KrisThielemans
Copy link
Member Author

Still postponing, as it will likely create installation problems. Also, ROOT interferes with error handling and gives rather confusing messages when there's a segfault (leading people to think it's a ROOT problem).

@KrisThielemans KrisThielemans modified the milestones: v2.0, v2.1 Feb 15, 2019
@KrisThielemans KrisThielemans modified the milestones: v2.1, v2.2 Oct 6, 2019
@KrisThielemans KrisThielemans modified the milestones: v3.1, v3.2 May 20, 2021
paskino pushed a commit to paskino/SIRF-SuperBuild that referenced this issue Oct 25, 2021
@KrisThielemans @paskino
don't set HOME and run UPDATE as the user (SyneRBI#98)
b9502f2 
* don't set HOME and run UPDATE as the user

This should resolve some issues with pip not being able to cache,
and is cleaner anyway

Closes SyneRBI#96

* replaced explicit sirfuser

* sets home environment variable to the home directory

* nbstripout in user path is not picked with sudo -u

* remove hold on grub

seems that SyneRBI#21 was somehow connected with the base box box-cutter/ubuntu1604
with current ubuntu/xenial64 the hold trick doesn't seem to be necessary.
@KrisThielemans KrisThielemans mentioned this issue Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4
Development

Successfully merging a pull request may close this issue.

Add the CERN ROOT library (used by STIR) KrisThielemans/SIRF-SuperBuild
1 participant
@KrisThielemans