Typo in parallelproj source code

[samdporter]

/devel/build/sources/parallelproj/c/include/parallelproj_c.h

line 284
typo: short n_tofbins;
correction: short n_tofbins,

I didn't know exactly where this came from in SIRF/STIR so didn't do a PR

Tested after this correction and SIRF builds fine on master branch

[KrisThielemans]

Hi. this file comes from parallelproj, specifically https://github.com/gschramm/parallelproj/blob/master/c/include/parallelproj_c.h. It looks fine there. Could you check versions etc?

[samdporter]

Old version of parallelproj (v1.0.0)
Shall I close?

[KrisThielemans]

did it give STIR compilation problems? Maybe only with the TOF branch? If not, we could raise the parallelproj minimum version in STIR's CMakeLists.txt, and even the SIRF-SuperBuild's version_config.cmake.

(I guess SIRF never sees parallelproj itself, so not sure if this issue was in the right place).

[samdporter]

Yes, it gave STIR compilation problems on the master branch

[KrisThielemans]

ok. Please check in which version of parallelproj this was fixed and generate a PR on STIR at https://github.com/UCL/STIR/blob/ea105a0ce2299afe2e598f249ecbe69de988b7c2/CMakeLists.txt#L200 accordingly and the SIRF-SuperBuild at

SIRF-SuperBuild/version_config.cmake

Line 282 in 79cc17a

set(parallelproj_REQUIRED_VERSION "1.0")

.

I'll transfer this issue

[KrisThielemans]

This was fixed in parallelproj 1.0.1. STIR now requires that. I think we can just close this here.