Soundwave dock now loads sound layers from canvas

[rodolforg]

Fix #1346

[rodolforg]

It now has issues with Canvas Time model beginning being shifted from 0f. I'll fix that later.

Anyway, tell me what you think about how we should name items in sound layer combobox…

Currently it uses filename listed in sound layer parameter.

[lgtm-com]

This pull request introduces 1 alert when merging 24de809 into 7d0ef7e - view on LGTM.com

new alerts:

• 1 for Catching by value

[rodolforg]

I see one problem here: popping the combobox is not good :(

[rodolforg]

@morevnaproject could you test it?

[morevnaproject]

Testing now! Thank you! ^__^

[morevnaproject]

The feature works great!

For name in combobox I suggestto display it in the following way:

• [LAYER_NAME] - /path/to/file.wav

Also I suggest to shorten path to file if it is too long.
I.e. for "/very/very/very/very/very/long/path/to/file.wav" display it like "...ry/long/path/to/file.wav".

[rodolforg]

Is this way better?

[morevnaproject]

I tested it and for some reason it doesn't shows filepath -

[rodolforg]

It only shows if it is different of layer description ("name"). Should it be always visible?

[morevnaproject]

Should it be always visible?

Yes, I think it's better to make it always visible. ^__^

Also, I just realized that it would be nice if combobox choices will appear above of combobox itself. Just like we did for Blend Method's parameter combobox - #650 (comment)

[rodolforg]

I realize that synfig::CanvasFileNaming::make_short_filename() doesn't ellipsize long strings, it creates a relative path (which usually shortens the name).

How many chars would have a long filename?
In order to implement your example:

I.e. for "/very/very/very/very/very/long/path/to/file.wav" display it like "...ry/long/path/to/file.wav".

[morevnaproject]

How many chars would have a long filename?

I guess, 30 is enough. ^__^

[rodolforg]

Done :)

[morevnaproject]

Thank you, it works perfectly now! Can you rebase, please? ^__^

[rodolforg]

Done :)

[morevnaproject]

Thank you for an awesome feature! ^__^