ConnectNamedPipe fails

[svenbw]

Sometimes this function fails although there is a pipe created.
It seems that the CreateNamedPipe function can report that the connection is complete when it's not ready yet.

Changing the code by checking on the 535 (ERROR_PIPE_CONNECTED) seems to overcome this issue.

//failed to connect client pipe
if ((success != 1) && (Marshal.GetLastWin32Error() != 535))
{
    break;
}

[synhershko]

I'll take a look at that in a few days, thanks

[synhershko]

Checking for an error like you suggested doesn't seem to be the right way to do this. Can you please check the latest version where I made a small correction?

[synhershko]

I'm assuming this issue is fixed, then

[pherrera]

The comment by svenbw is right, you need to do that change because ERROR_PIPE_CONNECTED can be returned as an "error" in some scenarios, you're currently just assuming it's not connected when it is.

[synhershko]

I've refactored this code (locally, haven't pushed yet), will take another look at this soon

[robinwassen]

@synhershko You have fixed this, so I think you can close it:

NAppUpdate/src/NAppUpdate.Framework/Utils/NauIpc.cs

Line 134 in bc22bb4

internal static void ConnectPipe(object stateObject)

[robinwassen]

Nevermind, might need to be fixed here too:

NAppUpdate/src/NAppUpdate.Framework/Utils/NauIpc.cs

Line 93 in bc22bb4

using (state.clientPipeHandle = CreateNamedPipe(

[robinwassen]

Closing as duplicate of #54