Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRE in SimpleWebSource.GetData() #31

Closed
CodingGorilla opened this issue Nov 9, 2012 · 2 comments
Closed

NRE in SimpleWebSource.GetData() #31

CodingGorilla opened this issue Nov 9, 2012 · 2 comments

Comments

@CodingGorilla
Copy link

If you have a update feed that does not specify a BaseUrl attribute on the feed element, then the UpdateManager.BaseUrl property is left null. When the SimpleWebSource.GetData() method is invoked, it does:

if (!baseUrl.EndsWith("/")) baseUrl += "/";

Which results in a NullReferenceException.

At a minimum there should be a String.IsNullOrEmpty() check on baseUrl, but it might be a good idea to make the UpdateManager.BaseUrl property public so it an be set by the client code.

@synhershko
Copy link
Owner

Thanks. Already fixed locally by adding a null check. I'm mid-work on some other issues and will push once done.

@synhershko
Copy link
Owner

Pushed now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants