Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beignet creates tx with fee bellow Minimal if amout is small #73

Open
limpbrains opened this issue Aug 14, 2024 · 2 comments
Open

Beignet creates tx with fee bellow Minimal if amout is small #73

limpbrains opened this issue Aug 14, 2024 · 2 comments

Comments

@limpbrains
Copy link
Collaborator

limpbrains commented Aug 14, 2024

When the fees are 4,4,4 and you are trying to create tx with small amount (~700 sats) beignet will reduce tx fee and set it bellow 4. It also do not allow to rase it, because of the "Error: Unable to increase the fee any further. Otherwise, it will exceed half the current sending/output amount." rule.

I think this rule should be ignored, beignet should not create tx with such a small fee, it will not be broadcasted

@pwltr
Copy link
Collaborator

pwltr commented Aug 15, 2024

Agreed, this rule has been causing issues. If we want to keep the warning maybe we can have a flag (and string) in the result
of the fee setting method. Then the UI can decide what to do with the warning.

Also see synonymdev/bitkit#1704

@limpbrains
Copy link
Collaborator Author

Maybe only use this rule if the amount sent is greater than 10000 sats or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants