Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct criticalsection managment and move some declaration to handle HttpAPI in Windows. #417

Closed
David-Nardi opened this issue Dec 2, 2021 · 2 comments

Comments

@David-Nardi
Copy link

OK, I'me aware to use Git/TortoiseGit so I send an issue.

There is a problem in criticalsection mamagment so I change SynCommons.pas :

  • Replace fLocked to Integer frm boolean (to manage nested calls)
  • Correct function TSynLocker.TryLock function to NOT CHECK fLocked !

And I have move declaration and procedure to handle correctly SSL certificate (I create separate unit to do this) in SynCrtSock.pas

mORMot.zip

@synopse
Copy link
Owner

synopse commented Dec 2, 2021

Should have been fixed inbetween by 136f3b0

@synopse
Copy link
Owner

synopse commented Dec 3, 2021

Moving all http.sys declarations into interface part is a huge step, which breaks existing unit layout.

It has been done properly in mORMot 2, and I guess https://github.com/synopse/mORMot2/blob/master/src/lib/mormot.lib.winhttp.pas is what you expect in fact.

But for mORMot 1, I wouldn't do this, it would be confusing for sure for the SynCrtSock unit which is already huge.

Please discuss any further in the forum.

@synopse synopse closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants